From: Paolo Bonzini <pbonzini@redhat.com>
To: quintela@redhat.com
Cc: kwolf@redhat.com, owasserm@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] migration: use a single I/O operation when writev_buffer is not defined
Date: Tue, 09 Apr 2013 13:42:48 +0200 [thread overview]
Message-ID: <5163FEB8.9050007@redhat.com> (raw)
In-Reply-To: <87d2u4djcg.fsf@elfo.elfo>
Il 09/04/2013 13:38, Juan Quintela ha scritto:
> And this
>
>
>
> is not needed if we just put the code inside add_to_iovec() no?
>
> Users of add_to_iovec() should not care if we are using vritev or
> put_buffer() right.
I'm taking the opposite stance here. add_to_iovec() should not be
called at all if using put_buffer.
> and as a second note. Having qemu_put_buffer_async() calling
> qemu_put_buffer() and qemu_put_buffer() calling qemu_put_buffer_async()
> is ..... weird?
Yes, in fact after this patch qemu_put_buffer() is not calling
qemu_put_buffer_async() anymore.
Paolo
next prev parent reply other threads:[~2013-04-09 11:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 11:29 [Qemu-devel] [PATCH 0/4] QEMUFile improvements and simplifications Paolo Bonzini
2013-04-08 11:29 ` [Qemu-devel] [PATCH 1/4] migration: set f->is_write and flush in add_to_iovec Paolo Bonzini
2013-04-09 11:32 ` Juan Quintela
2013-04-09 11:39 ` Paolo Bonzini
2013-04-08 11:29 ` [Qemu-devel] [PATCH 2/4] migration: use a single I/O operation when writev_buffer is not defined Paolo Bonzini
2013-04-09 11:38 ` Juan Quintela
2013-04-09 11:42 ` Paolo Bonzini [this message]
2013-04-08 11:29 ` [Qemu-devel] [PATCH 3/4] migration: drop is_write complications Paolo Bonzini
2013-04-09 11:42 ` Juan Quintela
2013-04-09 11:55 ` Paolo Bonzini
2013-04-09 12:17 ` Juan Quintela
2013-04-09 12:25 ` Paolo Bonzini
2013-04-08 11:29 ` [Qemu-devel] [PATCH 4/4] migration: simplify writev vs. non-writev logic Paolo Bonzini
2013-04-09 11:43 ` Juan Quintela
2013-04-09 11:53 ` Paolo Bonzini
2013-04-09 12:16 ` Juan Quintela
2013-04-09 12:22 ` Orit Wasserman
2013-04-09 12:58 ` [Qemu-devel] [PATCH 0/4] QEMUFile improvements and simplifications Juan Quintela
2013-04-10 12:48 ` Liuji (Jeremy)
2013-04-10 12:53 ` Paolo Bonzini
2013-04-10 18:29 ` Juan Quintela
2013-04-11 12:35 ` Liuji (Jeremy)
2013-04-10 12:55 ` Juan Quintela
2013-04-11 12:38 ` Liuji (Jeremy)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5163FEB8.9050007@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=owasserm@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).