From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"KONRAD Frédéric" <fred.konrad@greensocs.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
Date: Tue, 09 Apr 2013 13:48:57 +0200 [thread overview]
Message-ID: <51640029.4080802@redhat.com> (raw)
In-Reply-To: <874nfgj60n.fsf@blackfin.pond.sub.org>
Il 09/04/2013 13:30, Markus Armbruster ha scritto:
>>> >> We have two virtio-9p.h:
>>> >> ./hw/9pfs/virtio-9p.h
>>> >> ./include/hw/virtio/virtio-9p.h
>>> >>
>>> >> which can be confusing.
>> >
>> > Yes, the first one is only included with a local path. Though I think
>> > this is what confused my scripts.
> It'll confuse maintenance programmers, too. Rename one of them? For
> what it's worth, the second was named virtio-9p-device.h until you
> renamed & moved it.
The second isn't named virtio-9p.h. It is named hw/virtio/virtio-9p.h.
There is no -Iinclude/hw/virtio path, so you need the full path to
include it.
If you look at Linux, you have similarly include/scsi/scsi.h (for
#include <scsi/scsi.h>) and drivers/scsi/scsi.h (for #include "scsi.h").
Paolo
next prev parent reply other threads:[~2013-04-09 11:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 8:22 [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge Hans de Goede
2013-04-09 8:36 ` Paolo Bonzini
2013-04-09 9:30 ` KONRAD Frédéric
2013-04-09 9:36 ` Paolo Bonzini
2013-04-09 11:15 ` KONRAD Frédéric
2013-04-09 11:30 ` Markus Armbruster
2013-04-09 11:48 ` Paolo Bonzini [this message]
2013-04-09 19:13 ` Anthony Liguori
2013-04-09 20:27 ` KONRAD Frédéric
2013-04-09 20:57 ` Anthony Liguori
2013-04-09 21:28 ` KONRAD Frédéric
2013-04-15 16:52 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51640029.4080802@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=fred.konrad@greensocs.com \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).