From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33534)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPZc6-0007k3-Op
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 10:33:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPZc1-0000jZ-Vj
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 10:33:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56178)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPZc1-0000jN-Ok
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 10:33:29 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r39EXT9U025335
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 9 Apr 2013 10:33:29 -0400
Message-ID: <516426B4.6070701@redhat.com>
Date: Tue, 09 Apr 2013 16:33:24 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1365503248-21275-1-git-send-email-pbonzini@redhat.com>
	<20130409111630.GB27374@redhat.com>
In-Reply-To: <20130409111630.GB27374@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: move vhost-net to
	config-host.mak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

Il 09/04/2013 13:16, Michael S. Tsirkin ha scritto:
>> > There is no reason why vhost-net should not work with TCG.
>> > Hence, put the limitation in hw/vhost-net.c, not straight in
>> > the config-*.mak files.
>> > 
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> If you want to enable vhost for tcg why not enable it,

Actually, vhost is already enabled for TCG, and doesn't work because
nothing triggers the host notifiers.  I thought there was an "if
(kvm_enabled())" somewhere, but there isn't.  It is not enabled for
TCG-only targets, which makes even less sense...

> and fix any fallout?

I don't want to enable vhost for TCG.  What I want to do is limit
config-target.mak to things that are really target-dependent.

Anyway, I found an old patch from Stefan to fix vhost with TCG.  When
I'll have time I'll submit both.  Scrap this patch for now.

Paolo