From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPZuT-0001du-FO for qemu-devel@nongnu.org; Tue, 09 Apr 2013 10:52:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPZuR-0008RY-Td for qemu-devel@nongnu.org; Tue, 09 Apr 2013 10:52:33 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60108 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPZuR-0008RS-Ni for qemu-devel@nongnu.org; Tue, 09 Apr 2013 10:52:31 -0400 Message-ID: <51642B2E.5010407@suse.de> Date: Tue, 09 Apr 2013 16:52:30 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1364300401-9340-1-git-send-email-peter.maydell@linaro.org> <5151B249.6050602@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] sh7750: Fix crash when accessing PVR/PRR/CVR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org Am 08.04.2013 14:52, schrieb Peter Maydell: > On 26 March 2013 14:35, Andreas F=C3=A4rber wrote: >> Am 26.03.2013 13:20, schrieb Peter Maydell: >>> Commit b350ab75 causes segfaults on accesses to PVR/PRR/CVR because >>> it tries to call SUPERH_CPU_GET_CLASS() on a pointer that isn't a >>> QOM object. Fix this by getting the actual QOM CPU object first. >>> >>> Signed-off-by: Peter Maydell >>> --- >>> Tested with the r2d image/instructions from >>> https://oss.renesas.com/modules/document/?Getting%20Started%20with%20= SH4%20and%20QEMU >> >> Oops, reproduces with the test image from the QEMU Wiki as well. Seems >> to be a result of cherry-picking this commit before the full SH7750 >> QOM'ification. >> >> Is this blocking any work of yours? Otherwise I would try rebasing my >> SH7750 patches so that s->cpu becomes a SuperHCPU as expected here. >> (Not sure if simply reverting my offending patch still works?) >=20 > Ping -- were you planning to submit these patches soon or should > we just commit this patch to fix the breakage for now? Submitted now, sorry for the delay. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg