From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40775)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UPZy9-0007jj-N1
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 10:56:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UPZy8-0001fi-Hi
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 10:56:21 -0400
Received: from mail-qc0-x236.google.com ([2607:f8b0:400d:c01::236]:36579)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UPZy8-0001fW-Ek
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 10:56:20 -0400
Received: by mail-qc0-f182.google.com with SMTP id k19so3097411qcs.27
	for <qemu-devel@nongnu.org>; Tue, 09 Apr 2013 07:56:19 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51642C0C.6010607@redhat.com>
Date: Tue, 09 Apr 2013 16:56:12 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1365511954-10606-1-git-send-email-pbonzini@redhat.com>
	<8738uzet89.fsf@blackfin.pond.sub.org>
In-Reply-To: <8738uzet89.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] migration: initialize RAM to zero
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, pl@kamp.de, qemu-devel@nongnu.org, owasserm@redhat.com, stefanha@redhat.com

Il 09/04/2013 15:20, Markus Armbruster ha scritto:
>> > -#if defined(CONFIG_VALGRIND)
>> > -    if (running_on_valgrind < 0) {
>> > -        /* First call, test whether we are running on Valgrind.
>> > -           This is a substitute for RUNNING_ON_VALGRIND from valgrind.h. */
>> > -        const char *ld = getenv("LD_PRELOAD");
>> > -        running_on_valgrind = (ld != NULL && strstr(ld, "vgpreload"));
>> > +    if ((intptr_t) ptr == -1) {
> Recommend ptr == MAP_FAILED
> 

Worth respinning?

Paolo