From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPa6w-0007rG-1w for qemu-devel@nongnu.org; Tue, 09 Apr 2013 11:05:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPa6r-0005Ph-D5 for qemu-devel@nongnu.org; Tue, 09 Apr 2013 11:05:26 -0400 Received: from greensocs.com ([87.106.252.221]:52783 helo=s15328186.onlinehome-server.info) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPa6r-0005PF-7u for qemu-devel@nongnu.org; Tue, 09 Apr 2013 11:05:21 -0400 Message-ID: <51642E26.1010702@greensocs.com> Date: Tue, 09 Apr 2013 17:05:10 +0200 From: =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= MIME-Version: 1.0 References: <1365512016-21944-1-git-send-email-fred.konrad@greensocs.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 0/7] virtio-serial refactoring. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: amit.shah@redhat.com, cornelia.huck@de.ibm.com, Anthony Liguori , mark.burton@greensocs.com, qemu-devel@nongnu.org On 09/04/2013 16:53, Peter Maydell wrote: > On 9 April 2013 13:53, wrote: >> From: KONRAD Frederic >> >> This is the next part of virtio-refactoring. >> >> Basically it creates virtio-serial device which extends virtio-device. >> Then a virtio-serial can be connected on a virtio-bus. >> virtio-serial-pci, virtio-serial-s390 and virtio-serial-ccw are created too, >> they extend respectively virtio-pci, virtio-s390-device, virtio-ccw-device and >> have a virtio-serial. >> >> Tested-by: Cornelia Huck >> Reviewed-by: Cornelia Huck >> Reviewed-by: Peter Maydell > Note to Anthony -- the way Fred has put the R-b: tags in > his cover letter here seems to confuse your 'patches' > script. 'patches apply' applies the patches and adds these > tags to every patch in the series, but > patches list id:1365512016-21944-1-git-send-email-fred.konrad@greensocs.com > status:reviewed > > produces no output. > > I flag this up because this patch series will probably not appear > on your radar otherwise. > > Fred: the usual convention is to put reviewed-by > tags on the patches themselves when resending, even > if the reviewers were lazy and replied to the coverletter. > > thanks > -- PMM Sorry for that, I'm not too aware of this patches scripts and thought it had the same result. Do you want me to resend with the r-b tags inside each patches? Fred