Re: [Qemu-devel] [PATCH] Revert "New QMP command query-cpu-max and HMP command cpu_max"

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]

On 04/09/2013 08:23 AM, Michal Novotny wrote:
> This reverts commit 4d700430a20b3d53b7b15bc5f6666f7e570e3f2c as asked by
> Luiz. The patch has been obsoleted by extending MachineInfo structure
> by cpu-max field.
> 
> Signed-off-by: Michal Novotny <minovotn@redhat.com>
> ---
>  hmp-commands.hx  |  2 --
>  hmp.c            |  8 --------
>  hmp.h            |  1 -
>  monitor.c        |  7 -------
>  qapi-schema.json | 11 -----------
>  qmp-commands.hx  | 22 ----------------------
>  vl.c             |  5 -----
>  7 files changed, 56 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

Safe if taken in time for 1.5 alongside the MachineInfo improvements.
Libvirt has not yet coded up support to use either method, and is just
fine using the method that gets cemented by the 1.5 release.

>  ##
> -## @query-cpu-max
> -##
> -## query maximum number of CPUs supported by machine
> -##
> -## Returns: number of CPUs
> -##
> -## Since: 1.5
> -###
> -{ 'command': 'query-cpu-max', 'returns': 'int' }

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]