From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34111)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPbzG-00050B-Dy
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 13:05:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPbzF-0001PZ-7D
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 13:05:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42914)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPbzE-0001PR-Vm
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 13:05:37 -0400
Message-ID: <516449A6.1090502@redhat.com>
Date: Tue, 09 Apr 2013 19:02:30 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1365476681-31593-1-git-send-email-mrhines@linux.vnet.ibm.com>
	<1365476681-31593-9-git-send-email-mrhines@linux.vnet.ibm.com>
In-Reply-To: <1365476681-31593-9-git-send-email-mrhines@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v5: 08/12] new
 capabilities added and check for QMP string 'rdma'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: mrhines@linux.vnet.ibm.com
Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com

Il 09/04/2013 05:04, mrhines@linux.vnet.ibm.com ha scritto:
> +    } else if (strstart(uri, "rdma:", &p)) {
> +        rdma_start_outgoing_migration(s, p, &local_err);

Forgot one: please wrap this and the equivalent incoming migration hunk
with #ifdef CONFIG_RDMA.

Prototypes can go in include/migration/migration.h.

Paolo