From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH qom-cpu 2/2] sh7750: Change cpu field type to SuperHCPU
Date: Tue, 09 Apr 2013 19:10:29 +0200 [thread overview]
Message-ID: <51644B85.705@suse.de> (raw)
In-Reply-To: <CAFEAcA8HWNpeQEvTDAXJ9ak7ZGsioOK1od4bPvTn9UCoNNKiJA@mail.gmail.com>
Am 09.04.2013 17:29, schrieb Peter Maydell:
> On 9 April 2013 15:51, Andreas Färber <afaerber@suse.de> wrote:
>> This brings us a step closer to QOM'ified SH7750 SoC and
>> fixes b350ab75 (target-sh4: Move PVR/PRR/CVR into SuperHCPUClass)
>> assuming SuperHCPU type for SUPERH_CPU_GET_CLASS().
>>
>> Fix Coding Style issues while at it (indentation, braces).
>>
>> Reported-by: Peter Maydell <peter.maydell@linaro.org>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> My test sh4 image boots again now.
Thanks, applied both to qom-cpu:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu
If Aurélien wants to apply these directly, that should work, too.
Andreas
>
> thanks
> -- PMM
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-04-09 17:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 14:51 [Qemu-devel] [PATCH qom-cpu 0/2] target-sh4: SuperHCPU fixups Andreas Färber
2013-04-09 14:51 ` [Qemu-devel] [PATCH qom-cpu 1/2] shix: Catch CPU initialization errors Andreas Färber
2013-04-09 15:05 ` Peter Maydell
2013-04-09 14:51 ` [Qemu-devel] [PATCH qom-cpu 2/2] sh7750: Change cpu field type to SuperHCPU Andreas Färber
2013-04-09 15:29 ` Peter Maydell
2013-04-09 17:10 ` Andreas Färber [this message]
2013-04-13 12:35 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51644B85.705@suse.de \
--to=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).