From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51548)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1UPcxA-0007Wq-TI
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 14:07:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1UPcx5-0006hr-Bq
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 14:07:32 -0400
Received: from e39.co.us.ibm.com ([32.97.110.160]:40080)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1UPcx5-0006he-2X
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 14:07:27 -0400
Received: from /spool/local
	by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mrhines@linux.vnet.ibm.com>;
	Tue, 9 Apr 2013 12:07:25 -0600
Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233])
	by d01dlp02.pok.ibm.com (Postfix) with ESMTP id B0D0B6E8076
	for <qemu-devel@nongnu.org>; Tue,  9 Apr 2013 14:07:17 -0400 (EDT)
Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217])
	by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r39I7J8C205630
	for <qemu-devel@nongnu.org>; Tue, 9 Apr 2013 14:07:20 -0400
Received: from d01av03.pok.ibm.com (loopback [127.0.0.1])
	by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	r39I7HsE022667
	for <qemu-devel@nongnu.org>; Tue, 9 Apr 2013 15:07:18 -0300
Message-ID: <516458C9.3010108@linux.vnet.ibm.com>
Date: Tue, 09 Apr 2013 14:07:05 -0400
From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1365476681-31593-1-git-send-email-mrhines@linux.vnet.ibm.com>
	<1365476681-31593-2-git-send-email-mrhines@linux.vnet.ibm.com>
	<51644A6D.7030003@redhat.com>
In-Reply-To: <51644A6D.7030003@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v5: 01/12] ./configure
 with and without --enable-rdma
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com

Thanks for all the comments...... will implement......


On 04/09/2013 01:05 PM, Paolo Bonzini wrote:
> Il 09/04/2013 05:04, mrhines@linux.vnet.ibm.com ha scritto:
>> +if test "$rdma" = "yes" ; then
>> +  cat > $TMPC <<EOF
>> +#include <rdma/rdma_cma.h>
>> +int main(void) { return 0; }
>> +EOF
>> +  rdma_libs="-lrdmacm -libverbs"
>> +  if ! compile_prog "" "$rdma_libs" ; then
>> +      feature_not_found "rdma"
>> +  fi
>> +
> Please enable this by default, or it will bitrot.
>
> The test should be like this:
>
> if test "$rdma" != "no" ; then
>    cat > $TMPC << EOF
> ...
> EOF
>    rdma_libs="-lrdmacm -libverbs"
>    if compile_prog "-Werror" "$rdma_libs" ; then
>      rdma="yes"
>      libs_softmmu="$libs_softmmu $rdma_libs"
>    else
>      if test "$rdma" = "yes" ; then
>        feature_not_found "rdma"
>      fi
>      rdma="no"
>    fi
> fi
>
>
> ...
>
> if test "$rdma" = "yes" ; then
>    echo "CONFIG_RDMA=y" >> $config_host_mak
> fi
>