From: "KONRAD Frédéric" <fred.konrad@greensocs.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
Date: Tue, 09 Apr 2013 22:27:40 +0200 [thread overview]
Message-ID: <516479BC.30206@greensocs.com> (raw)
In-Reply-To: <87a9p7h606.fsf@codemonkey.ws>
On 09/04/2013 21:13, Anthony Liguori wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> Il 09/04/2013 10:22, Hans de Goede ha scritto:
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>> hw/9pfs/virtio-9p-device.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion
>> Ouch, /me installs libcap-ng-devel.
> On a fresh F18, I tried to find all the deps needed that can be
> reasonably installed. This is what I came up with:
>
> # yum install xen-devel iasl libfdt-devel libcap-ng-devel \
> spice-server-devel gnutls-devel cyrus-sasl-devel libjpeg-turbo-devel \
> libpng-devel uuid-devel xfsprogs-devel ncurses-devel brlapi-devel \
> libcurl-devel bluez-libs-devel libiscsi-devel libcap-ng-devel \
> spice-protocol SDL-devel libcap-devel usbredir-devel libseccomp-devel \
> ceph-devel
>
> Still missing GlusterFS, VDE, and iscsi. F18 doesn't seem to
> package these at appropriate versions.
>
> Regards,
>
> Anthony Liguori
Isn't libattr-devel needed as well for virtio-9p?
I needed it to test my patch-set this morning.
>
>> Thanks.
>>
>> Paolo
>>
>>> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
>>> index 43f930e..b476b81 100644
>>> --- a/hw/9pfs/virtio-9p-device.c
>>> +++ b/hw/9pfs/virtio-9p-device.c
>>> @@ -12,11 +12,11 @@
>>> */
>>>
>>> #include "hw/virtio/virtio.h"
>>> +#include "hw/virtio/virtio-9p.h"
>>> #include "hw/i386/pc.h"
>>> #include "qemu/sockets.h"
>>> #include "virtio-9p.h"
>>> #include "fsdev/qemu-fsdev.h"
>>> -#include "virtio-9p-device.h"
>>> #include "virtio-9p-xattr.h"
>>> #include "virtio-9p-coth.h"
>>>
>>>
next prev parent reply other threads:[~2013-04-09 20:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 8:22 [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge Hans de Goede
2013-04-09 8:36 ` Paolo Bonzini
2013-04-09 9:30 ` KONRAD Frédéric
2013-04-09 9:36 ` Paolo Bonzini
2013-04-09 11:15 ` KONRAD Frédéric
2013-04-09 11:30 ` Markus Armbruster
2013-04-09 11:48 ` Paolo Bonzini
2013-04-09 19:13 ` Anthony Liguori
2013-04-09 20:27 ` KONRAD Frédéric [this message]
2013-04-09 20:57 ` Anthony Liguori
2013-04-09 21:28 ` KONRAD Frédéric
2013-04-15 16:52 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516479BC.30206@greensocs.com \
--to=fred.konrad@greensocs.com \
--cc=anthony@codemonkey.ws \
--cc=hdegoede@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).