* [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
@ 2013-04-09 8:22 Hans de Goede
2013-04-09 8:36 ` Paolo Bonzini
2013-04-15 16:52 ` Anthony Liguori
0 siblings, 2 replies; 12+ messages in thread
From: Hans de Goede @ 2013-04-09 8:22 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Hans de Goede, qemu-devel, Paolo Bonzini
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
---
hw/9pfs/virtio-9p-device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index 43f930e..b476b81 100644
--- a/hw/9pfs/virtio-9p-device.c
+++ b/hw/9pfs/virtio-9p-device.c
@@ -12,11 +12,11 @@
*/
#include "hw/virtio/virtio.h"
+#include "hw/virtio/virtio-9p.h"
#include "hw/i386/pc.h"
#include "qemu/sockets.h"
#include "virtio-9p.h"
#include "fsdev/qemu-fsdev.h"
-#include "virtio-9p-device.h"
#include "virtio-9p-xattr.h"
#include "virtio-9p-coth.h"
--
1.8.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
2013-04-09 8:22 [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge Hans de Goede
@ 2013-04-09 8:36 ` Paolo Bonzini
2013-04-09 9:30 ` KONRAD Frédéric
2013-04-09 19:13 ` Anthony Liguori
2013-04-15 16:52 ` Anthony Liguori
1 sibling, 2 replies; 12+ messages in thread
From: Paolo Bonzini @ 2013-04-09 8:36 UTC (permalink / raw)
To: Hans de Goede, qemu-devel
Il 09/04/2013 10:22, Hans de Goede ha scritto:
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/9pfs/virtio-9p-device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Ouch, /me installs libcap-ng-devel.
Thanks.
Paolo
> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
> index 43f930e..b476b81 100644
> --- a/hw/9pfs/virtio-9p-device.c
> +++ b/hw/9pfs/virtio-9p-device.c
> @@ -12,11 +12,11 @@
> */
>
> #include "hw/virtio/virtio.h"
> +#include "hw/virtio/virtio-9p.h"
> #include "hw/i386/pc.h"
> #include "qemu/sockets.h"
> #include "virtio-9p.h"
> #include "fsdev/qemu-fsdev.h"
> -#include "virtio-9p-device.h"
> #include "virtio-9p-xattr.h"
> #include "virtio-9p-coth.h"
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
2013-04-09 8:36 ` Paolo Bonzini
@ 2013-04-09 9:30 ` KONRAD Frédéric
2013-04-09 9:36 ` Paolo Bonzini
2013-04-09 19:13 ` Anthony Liguori
1 sibling, 1 reply; 12+ messages in thread
From: KONRAD Frédéric @ 2013-04-09 9:30 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Hans de Goede, qemu-devel
On 09/04/2013 10:36, Paolo Bonzini wrote:
> Il 09/04/2013 10:22, Hans de Goede ha scritto:
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> hw/9pfs/virtio-9p-device.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> Ouch, /me installs libcap-ng-devel.
>
> Thanks.
>
> Paolo
>
>> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
>> index 43f930e..b476b81 100644
>> --- a/hw/9pfs/virtio-9p-device.c
>> +++ b/hw/9pfs/virtio-9p-device.c
>> @@ -12,11 +12,11 @@
>> */
>>
>> #include "hw/virtio/virtio.h"
>> +#include "hw/virtio/virtio-9p.h"
[..]
>> #include "virtio-9p.h"
Is that normal?
We have two virtio-9p.h:
./hw/9pfs/virtio-9p.h
./include/hw/virtio/virtio-9p.h
which can be confusing.
is it not better to re-rename virtio-9p.h => virtio-9p-device.h?
>> -#include "virtio-9p-device.h"
>>
>>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
2013-04-09 9:30 ` KONRAD Frédéric
@ 2013-04-09 9:36 ` Paolo Bonzini
2013-04-09 11:15 ` KONRAD Frédéric
2013-04-09 11:30 ` Markus Armbruster
0 siblings, 2 replies; 12+ messages in thread
From: Paolo Bonzini @ 2013-04-09 9:36 UTC (permalink / raw)
To: KONRAD Frédéric; +Cc: Hans de Goede, qemu-devel
Il 09/04/2013 11:30, KONRAD Frédéric ha scritto:
>>>
>>> #include "hw/virtio/virtio.h"
>>> +#include "hw/virtio/virtio-9p.h"
> [..]
>>> #include "virtio-9p.h"
> Is that normal?
>
> We have two virtio-9p.h:
> ./hw/9pfs/virtio-9p.h
> ./include/hw/virtio/virtio-9p.h
>
> which can be confusing.
Yes, the first one is only included with a local path. Though I think
this is what confused my scripts.
Paolo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
2013-04-09 9:36 ` Paolo Bonzini
@ 2013-04-09 11:15 ` KONRAD Frédéric
2013-04-09 11:30 ` Markus Armbruster
1 sibling, 0 replies; 12+ messages in thread
From: KONRAD Frédéric @ 2013-04-09 11:15 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Hans de Goede, qemu-devel
On 09/04/2013 11:36, Paolo Bonzini wrote:
> Il 09/04/2013 11:30, KONRAD Frédéric ha scritto:
>>>> #include "hw/virtio/virtio.h"
>>>> +#include "hw/virtio/virtio-9p.h"
>> [..]
>>>> #include "virtio-9p.h"
>> Is that normal?
>>
>> We have two virtio-9p.h:
>> ./hw/9pfs/virtio-9p.h
>> ./include/hw/virtio/virtio-9p.h
>>
>> which can be confusing.
> Yes, the first one is only included with a local path. Though I think
> this is what confused my scripts.
>
> Paolo
Ok, so you'll keep the same name for both files?
Thanks,
Fred
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
2013-04-09 9:36 ` Paolo Bonzini
2013-04-09 11:15 ` KONRAD Frédéric
@ 2013-04-09 11:30 ` Markus Armbruster
2013-04-09 11:48 ` Paolo Bonzini
1 sibling, 1 reply; 12+ messages in thread
From: Markus Armbruster @ 2013-04-09 11:30 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Hans de Goede, qemu-devel, KONRAD Frédéric
Paolo Bonzini <pbonzini@redhat.com> writes:
> Il 09/04/2013 11:30, KONRAD Frédéric ha scritto:
>>>>
>>>> #include "hw/virtio/virtio.h"
>>>> +#include "hw/virtio/virtio-9p.h"
>> [..]
>>>> #include "virtio-9p.h"
>> Is that normal?
>>
>> We have two virtio-9p.h:
>> ./hw/9pfs/virtio-9p.h
>> ./include/hw/virtio/virtio-9p.h
>>
>> which can be confusing.
>
> Yes, the first one is only included with a local path. Though I think
> this is what confused my scripts.
It'll confuse maintenance programmers, too. Rename one of them? For
what it's worth, the second was named virtio-9p-device.h until you
renamed & moved it.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
2013-04-09 11:30 ` Markus Armbruster
@ 2013-04-09 11:48 ` Paolo Bonzini
0 siblings, 0 replies; 12+ messages in thread
From: Paolo Bonzini @ 2013-04-09 11:48 UTC (permalink / raw)
To: Markus Armbruster; +Cc: Hans de Goede, qemu-devel, KONRAD Frédéric
Il 09/04/2013 13:30, Markus Armbruster ha scritto:
>>> >> We have two virtio-9p.h:
>>> >> ./hw/9pfs/virtio-9p.h
>>> >> ./include/hw/virtio/virtio-9p.h
>>> >>
>>> >> which can be confusing.
>> >
>> > Yes, the first one is only included with a local path. Though I think
>> > this is what confused my scripts.
> It'll confuse maintenance programmers, too. Rename one of them? For
> what it's worth, the second was named virtio-9p-device.h until you
> renamed & moved it.
The second isn't named virtio-9p.h. It is named hw/virtio/virtio-9p.h.
There is no -Iinclude/hw/virtio path, so you need the full path to
include it.
If you look at Linux, you have similarly include/scsi/scsi.h (for
#include <scsi/scsi.h>) and drivers/scsi/scsi.h (for #include "scsi.h").
Paolo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
2013-04-09 8:36 ` Paolo Bonzini
2013-04-09 9:30 ` KONRAD Frédéric
@ 2013-04-09 19:13 ` Anthony Liguori
2013-04-09 20:27 ` KONRAD Frédéric
1 sibling, 1 reply; 12+ messages in thread
From: Anthony Liguori @ 2013-04-09 19:13 UTC (permalink / raw)
To: Paolo Bonzini, Hans de Goede, qemu-devel
Paolo Bonzini <pbonzini@redhat.com> writes:
> Il 09/04/2013 10:22, Hans de Goede ha scritto:
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> hw/9pfs/virtio-9p-device.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion
>
> Ouch, /me installs libcap-ng-devel.
On a fresh F18, I tried to find all the deps needed that can be
reasonably installed. This is what I came up with:
# yum install xen-devel iasl libfdt-devel libcap-ng-devel \
spice-server-devel gnutls-devel cyrus-sasl-devel libjpeg-turbo-devel \
libpng-devel uuid-devel xfsprogs-devel ncurses-devel brlapi-devel \
libcurl-devel bluez-libs-devel libiscsi-devel libcap-ng-devel \
spice-protocol SDL-devel libcap-devel usbredir-devel libseccomp-devel \
ceph-devel
Still missing GlusterFS, VDE, and iscsi. F18 doesn't seem to
package these at appropriate versions.
Regards,
Anthony Liguori
>
> Thanks.
>
> Paolo
>
>> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
>> index 43f930e..b476b81 100644
>> --- a/hw/9pfs/virtio-9p-device.c
>> +++ b/hw/9pfs/virtio-9p-device.c
>> @@ -12,11 +12,11 @@
>> */
>>
>> #include "hw/virtio/virtio.h"
>> +#include "hw/virtio/virtio-9p.h"
>> #include "hw/i386/pc.h"
>> #include "qemu/sockets.h"
>> #include "virtio-9p.h"
>> #include "fsdev/qemu-fsdev.h"
>> -#include "virtio-9p-device.h"
>> #include "virtio-9p-xattr.h"
>> #include "virtio-9p-coth.h"
>>
>>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
2013-04-09 19:13 ` Anthony Liguori
@ 2013-04-09 20:27 ` KONRAD Frédéric
2013-04-09 20:57 ` Anthony Liguori
0 siblings, 1 reply; 12+ messages in thread
From: KONRAD Frédéric @ 2013-04-09 20:27 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Paolo Bonzini, qemu-devel, Hans de Goede
On 09/04/2013 21:13, Anthony Liguori wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> Il 09/04/2013 10:22, Hans de Goede ha scritto:
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>> hw/9pfs/virtio-9p-device.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion
>> Ouch, /me installs libcap-ng-devel.
> On a fresh F18, I tried to find all the deps needed that can be
> reasonably installed. This is what I came up with:
>
> # yum install xen-devel iasl libfdt-devel libcap-ng-devel \
> spice-server-devel gnutls-devel cyrus-sasl-devel libjpeg-turbo-devel \
> libpng-devel uuid-devel xfsprogs-devel ncurses-devel brlapi-devel \
> libcurl-devel bluez-libs-devel libiscsi-devel libcap-ng-devel \
> spice-protocol SDL-devel libcap-devel usbredir-devel libseccomp-devel \
> ceph-devel
>
> Still missing GlusterFS, VDE, and iscsi. F18 doesn't seem to
> package these at appropriate versions.
>
> Regards,
>
> Anthony Liguori
Isn't libattr-devel needed as well for virtio-9p?
I needed it to test my patch-set this morning.
>
>> Thanks.
>>
>> Paolo
>>
>>> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
>>> index 43f930e..b476b81 100644
>>> --- a/hw/9pfs/virtio-9p-device.c
>>> +++ b/hw/9pfs/virtio-9p-device.c
>>> @@ -12,11 +12,11 @@
>>> */
>>>
>>> #include "hw/virtio/virtio.h"
>>> +#include "hw/virtio/virtio-9p.h"
>>> #include "hw/i386/pc.h"
>>> #include "qemu/sockets.h"
>>> #include "virtio-9p.h"
>>> #include "fsdev/qemu-fsdev.h"
>>> -#include "virtio-9p-device.h"
>>> #include "virtio-9p-xattr.h"
>>> #include "virtio-9p-coth.h"
>>>
>>>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
2013-04-09 20:27 ` KONRAD Frédéric
@ 2013-04-09 20:57 ` Anthony Liguori
2013-04-09 21:28 ` KONRAD Frédéric
0 siblings, 1 reply; 12+ messages in thread
From: Anthony Liguori @ 2013-04-09 20:57 UTC (permalink / raw)
To: KONRAD Frédéric; +Cc: Paolo Bonzini, qemu-devel, Hans de Goede
KONRAD Frédéric <fred.konrad@greensocs.com> writes:
> On 09/04/2013 21:13, Anthony Liguori wrote:
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>
>>> Il 09/04/2013 10:22, Hans de Goede ha scritto:
>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>>> ---
>>>> hw/9pfs/virtio-9p-device.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion
>>> Ouch, /me installs libcap-ng-devel.
>> On a fresh F18, I tried to find all the deps needed that can be
>> reasonably installed. This is what I came up with:
>>
>> # yum install xen-devel iasl libfdt-devel libcap-ng-devel \
>> spice-server-devel gnutls-devel cyrus-sasl-devel libjpeg-turbo-devel \
>> libpng-devel uuid-devel xfsprogs-devel ncurses-devel brlapi-devel \
>> libcurl-devel bluez-libs-devel libiscsi-devel libcap-ng-devel \
>> spice-protocol SDL-devel libcap-devel usbredir-devel libseccomp-devel \
>> ceph-devel
>>
>> Still missing GlusterFS, VDE, and iscsi. F18 doesn't seem to
>> package these at appropriate versions.
>>
>> Regards,
>>
>> Anthony Liguori
> Isn't libattr-devel needed as well for virtio-9p?
I have CONFIG_VIRTFS=y without libattr-devel installed FWIW.
Regards,
Anthony Liguori
>
> I needed it to test my patch-set this morning.
>>
>>> Thanks.
>>>
>>> Paolo
>>>
>>>> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
>>>> index 43f930e..b476b81 100644
>>>> --- a/hw/9pfs/virtio-9p-device.c
>>>> +++ b/hw/9pfs/virtio-9p-device.c
>>>> @@ -12,11 +12,11 @@
>>>> */
>>>>
>>>> #include "hw/virtio/virtio.h"
>>>> +#include "hw/virtio/virtio-9p.h"
>>>> #include "hw/i386/pc.h"
>>>> #include "qemu/sockets.h"
>>>> #include "virtio-9p.h"
>>>> #include "fsdev/qemu-fsdev.h"
>>>> -#include "virtio-9p-device.h"
>>>> #include "virtio-9p-xattr.h"
>>>> #include "virtio-9p-coth.h"
>>>>
>>>>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
2013-04-09 20:57 ` Anthony Liguori
@ 2013-04-09 21:28 ` KONRAD Frédéric
0 siblings, 0 replies; 12+ messages in thread
From: KONRAD Frédéric @ 2013-04-09 21:28 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Paolo Bonzini, qemu-devel, Hans de Goede
On 09/04/2013 22:57, Anthony Liguori wrote:
> KONRAD Frédéric <fred.konrad@greensocs.com> writes:
>
>> On 09/04/2013 21:13, Anthony Liguori wrote:
>>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>>
>>>> Il 09/04/2013 10:22, Hans de Goede ha scritto:
>>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>>>> ---
>>>>> hw/9pfs/virtio-9p-device.c | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion
>>>> Ouch, /me installs libcap-ng-devel.
>>> On a fresh F18, I tried to find all the deps needed that can be
>>> reasonably installed. This is what I came up with:
>>>
>>> # yum install xen-devel iasl libfdt-devel libcap-ng-devel \
>>> spice-server-devel gnutls-devel cyrus-sasl-devel libjpeg-turbo-devel \
>>> libpng-devel uuid-devel xfsprogs-devel ncurses-devel brlapi-devel \
>>> libcurl-devel bluez-libs-devel libiscsi-devel libcap-ng-devel \
>>> spice-protocol SDL-devel libcap-devel usbredir-devel libseccomp-devel \
>>> ceph-devel
>>>
>>> Still missing GlusterFS, VDE, and iscsi. F18 doesn't seem to
>>> package these at appropriate versions.
>>>
>>> Regards,
>>>
>>> Anthony Liguori
>> Isn't libattr-devel needed as well for virtio-9p?
> I have CONFIG_VIRTFS=y without libattr-devel installed FWIW.
>
> Regards,
>
> Anthony Liguori
True, I just tested.
But when I launch the configure script without libcap-devel installed:
[konradf@localhost qemu]$ ./configure [...] --enable-virtfs
ERROR: VirtFS is supported only on Linux and requires libcap-devel and
libattr-devel
That's why I installed it :).
>
>> I needed it to test my patch-set this morning.
>>>> Thanks.
>>>>
>>>> Paolo
>>>>
>>>>> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
>>>>> index 43f930e..b476b81 100644
>>>>> --- a/hw/9pfs/virtio-9p-device.c
>>>>> +++ b/hw/9pfs/virtio-9p-device.c
>>>>> @@ -12,11 +12,11 @@
>>>>> */
>>>>>
>>>>> #include "hw/virtio/virtio.h"
>>>>> +#include "hw/virtio/virtio-9p.h"
>>>>> #include "hw/i386/pc.h"
>>>>> #include "qemu/sockets.h"
>>>>> #include "virtio-9p.h"
>>>>> #include "fsdev/qemu-fsdev.h"
>>>>> -#include "virtio-9p-device.h"
>>>>> #include "virtio-9p-xattr.h"
>>>>> #include "virtio-9p-coth.h"
>>>>>
>>>>>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
2013-04-09 8:22 [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge Hans de Goede
2013-04-09 8:36 ` Paolo Bonzini
@ 2013-04-15 16:52 ` Anthony Liguori
1 sibling, 0 replies; 12+ messages in thread
From: Anthony Liguori @ 2013-04-15 16:52 UTC (permalink / raw)
To: Hans de Goede, Gerd Hoffmann
Applied. Thanks.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-04-15 16:52 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-09 8:22 [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge Hans de Goede
2013-04-09 8:36 ` Paolo Bonzini
2013-04-09 9:30 ` KONRAD Frédéric
2013-04-09 9:36 ` Paolo Bonzini
2013-04-09 11:15 ` KONRAD Frédéric
2013-04-09 11:30 ` Markus Armbruster
2013-04-09 11:48 ` Paolo Bonzini
2013-04-09 19:13 ` Anthony Liguori
2013-04-09 20:27 ` KONRAD Frédéric
2013-04-09 20:57 ` Anthony Liguori
2013-04-09 21:28 ` KONRAD Frédéric
2013-04-15 16:52 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).