From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPpht-0007YE-KT for qemu-devel@nongnu.org; Wed, 10 Apr 2013 03:44:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPphs-0007Rb-94 for qemu-devel@nongnu.org; Wed, 10 Apr 2013 03:44:37 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:38188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPpWJ-0002bz-2T for qemu-devel@nongnu.org; Wed, 10 Apr 2013 03:32:39 -0400 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 10 Apr 2013 17:25:35 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 296563578050 for ; Wed, 10 Apr 2013 17:32:27 +1000 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3A7IS3E59637814 for ; Wed, 10 Apr 2013 17:18:30 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3A7VtbU012412 for ; Wed, 10 Apr 2013 17:31:55 +1000 Message-ID: <51651502.8070101@linux.vnet.ibm.com> Date: Wed, 10 Apr 2013 15:30:10 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1364903250-10429-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1364903250-10429-12-git-send-email-xiawenc@linux.vnet.ibm.com> <20130408133354.GB4429@stefanha-thinkpad.redhat.com> In-Reply-To: <20130408133354.GB4429@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V11 11/17] qmp: add ImageInfo in BlockDeviceInfo used by query-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org 于 2013-4-8 21:33, Stefan Hajnoczi 写道: > On Tue, Apr 02, 2013 at 07:47:24PM +0800, Wenchao Xia wrote: >> diff --git a/qmp-commands.hx b/qmp-commands.hx >> index 6b20684..b856be7 100644 >> --- a/qmp-commands.hx >> +++ b/qmp-commands.hx >> @@ -1703,6 +1703,47 @@ Each json-object contain the following: >> - "iops": limit total I/O operations per second (json-int) >> - "iops_rd": limit read operations per second (json-int) >> - "iops_wr": limit write operations per second (json-int) >> + - "image": the detail of the image, it is a json-object containing >> + the following: >> + - "filename": image file name (json-string) >> + - "format": image format (json-string) >> + - "virtual-size": image capacity in bytes (json-int) >> + - "dirty-flag": true if image is not cleanly closed, not present >> + means clean (json-bool, optional) >> + - "actual-size": actual size on disk in bytes of the image, not >> + present when image does not support thin >> + provision (json-int, optional) >> + - "cluster-size": size of a cluster in bytes, not present if image >> + format does not support it (json-int, optional) >> + - "encrypted": true if the image is encrypted, not present means >> + false or the image format does not support >> + encryption (json-bool, optional) >> + - "backing_file": backing file name, not present means no backing >> + file is used or the image format does not >> + support backing file chain >> + (json-string, optional) >> + - "full-backing-filename": full path of the backing file, not >> + present if it equals backing_file or no >> + backing file is used >> + (json-string, optional) >> + - "backing-filename-format": the format of the backing file, not >> + present means unknown or no backing >> + file (json-string, optional) >> + - "snapshots": the internal snapshot info, it is an optional list >> + of json-object containing the following: >> + - "id": unique snapshot id (json-string) >> + - "name": snapshot name (json-string) >> + - "vm-state-size": size of the VM state in bytes (json-int) >> + - "date-sec": UTC date of the snapshot in seconds (json-int) >> + - "date-nsec": fractional part in nanoseconds to be used with >> + date-sec(json-int) >> + - "vm-clock-sec": VM clock relative to boot in seconds >> + (json-int) >> + - "vm-clock-nsec": fractional part in nanoseconds to be used >> + with vm-clock-sec (json-int) >> + - "backing-image": the detail of the backing image, it is an >> + optional json-object only present when a >> + backing image present for this image > > Please don't duplicate the ImageInfo documentation from > qapi-schema.json. > > I'm not sure how the documentation gets generated but we need to avoid > this, otherwise it will quickly get out of sync. > > Stefan > So remove this section? It seems no other way to sync them except manually change both of them. -- Best Regards Wenchao Xia