From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43785)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UPpwt-0001Sh-Fe
	for qemu-devel@nongnu.org; Wed, 10 Apr 2013 04:00:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UPpwo-0004CV-VM
	for qemu-devel@nongnu.org; Wed, 10 Apr 2013 04:00:07 -0400
Received: from mail-bk0-x234.google.com ([2a00:1450:4008:c01::234]:65076)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UPpwo-00049p-Nk
	for qemu-devel@nongnu.org; Wed, 10 Apr 2013 04:00:02 -0400
Received: by mail-bk0-f52.google.com with SMTP id it16so73291bkc.11
	for <qemu-devel@nongnu.org>; Wed, 10 Apr 2013 01:00:01 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51651BFB.2030102@redhat.com>
Date: Wed, 10 Apr 2013 09:59:55 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1365513468-1988-1-git-send-email-pbonzini@redhat.com>
	<CAFEAcA_WcLKkn7_WiTir77vgpgXKV+8ZJ1_DgX2tO9GP+t4V5Q@mail.gmail.com>
In-Reply-To: <CAFEAcA_WcLKkn7_WiTir77vgpgXKV+8ZJ1_DgX2tO9GP+t4V5Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] configure: remove duplicate test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

Il 09/04/2013 19:22, Peter Maydell ha scritto:
> On 9 April 2013 14:17, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> We already had a test to add -march=i486 when needed.  Make the
>> existing test independent of vhost-net, so that it is also used
>> under Win32.  Also move the test earlier to avoid mucking with
>> QEMU_CFLAGS too late in the configure process.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Do we care about passing this flag through to submodules?

I don't think so, submodules would have their own configure tests.

Paolo

> If so we probably need to do something with EXTRA_CFLAGS
> (cf Peter Crosthwaite's DTC submodule patches).
> 
> If not, this looks OK.
> 
> thanks
> -- PMM
> 
>