From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPq0C-0002Pu-3p for qemu-devel@nongnu.org; Wed, 10 Apr 2013 04:03:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPq0A-0005FF-KW for qemu-devel@nongnu.org; Wed, 10 Apr 2013 04:03:31 -0400 Received: from mail-bk0-x230.google.com ([2a00:1450:4008:c01::230]:47693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPq0A-0005FB-Dd for qemu-devel@nongnu.org; Wed, 10 Apr 2013 04:03:30 -0400 Received: by mail-bk0-f48.google.com with SMTP id jf3so74242bkc.21 for ; Wed, 10 Apr 2013 01:03:29 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51651CCB.1020600@redhat.com> Date: Wed, 10 Apr 2013 10:03:23 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1364914261-4237-1-git-send-email-pbonzini@redhat.com> <1364914261-4237-2-git-send-email-pbonzini@redhat.com> <51644FAB.1090908@suse.de> In-Reply-To: <51644FAB.1090908@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH 1/6] adlib: qdev-ify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: av1474@comtv.ru, qemu-devel@nongnu.org Il 09/04/2013 19:28, Andreas Färber ha scritto: >> > +#ifdef HAS_YMF262 >> > +#define ADLIB_DESC "Yamaha YMF262 (OPL3)" >> > +#else >> > +#define ADLIB_DESC "Yamaha YM3812 (OPL2)" >> > +#endif > Shouldn't in the process of QOM'ifying this be split into two devices? > Is HAS_YMF262 user-selected or dependent on libraries or something? > IIRC the OPL3 code is not under a GPL-compatible license (perhaps the MAME license?), the code is just there for people who want to combine it themselves. Paolo