From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPq3a-0006eL-DX for qemu-devel@nongnu.org; Wed, 10 Apr 2013 04:07:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPq3Z-0006Vz-29 for qemu-devel@nongnu.org; Wed, 10 Apr 2013 04:07:02 -0400 Received: from mail-bk0-x236.google.com ([2a00:1450:4008:c01::236]:45938) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPq3Y-0006Vq-R7 for qemu-devel@nongnu.org; Wed, 10 Apr 2013 04:07:00 -0400 Received: by mail-bk0-f54.google.com with SMTP id q16so76385bkw.27 for ; Wed, 10 Apr 2013 01:07:00 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51651D9C.5070000@redhat.com> Date: Wed, 10 Apr 2013 10:06:52 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1365172636-28628-1-git-send-email-imammedo@redhat.com> <1365172636-28628-9-git-send-email-imammedo@redhat.com> <1365387208.5674.38.camel@liguang.fnst.cn.fujitsu.com> <20130408133256.4f4a3fc8@nial.usersys.redhat.com> <5163FD4E.8050206@redhat.com> <1365553277.9553.82.camel@liguang.fnst.cn.fujitsu.com> In-Reply-To: <1365553277.9553.82.camel@liguang.fnst.cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace FROM_SYSBUS() with QOM type cast List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: li guang Cc: aliguori@us.ibm.com, ehabkost@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, Igor Mammedov , afaerber@suse.de, rth@twiddle.net Il 10/04/2013 02:21, li guang ha scritto: >>>>> > >> > >>>>> > >> > >>> > > sure, will do this on the next respin. >> > >> > Actually no, why? It's two different files. > because they do the same trivial thing, > do you want some mechanic changes separated? If it makes sense, yes. Paolo