From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPtnn-0003WU-LG for qemu-devel@nongnu.org; Wed, 10 Apr 2013 08:07:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPtnm-0002nC-8c for qemu-devel@nongnu.org; Wed, 10 Apr 2013 08:06:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPtnl-0002n4-Vu for qemu-devel@nongnu.org; Wed, 10 Apr 2013 08:06:58 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3AC6vb2017350 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 10 Apr 2013 08:06:57 -0400 Message-ID: <516555E0.8040405@redhat.com> Date: Wed, 10 Apr 2013 06:06:56 -0600 From: Eric Blake MIME-Version: 1.0 References: <451dff8502328bfb24afa139cbdfeeebc60d3e67.1364565637.git.phrdina@redhat.com> <87mwt7debf.fsf@blackfin.pond.sub.org> <51653798.9020806@redhat.com> In-Reply-To: <51653798.9020806@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2DTGSXJLMCXENAWGQTSRQ" Subject: Re: [Qemu-devel] [PATCH v4 02/11] block: add error parameter to del_existing_snapshots() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: lcapitulino@redhat.com, Markus Armbruster , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2DTGSXJLMCXENAWGQTSRQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/10/2013 03:57 AM, Pavel Hrdina wrote: >> Any particular reason for de-capitalizing "Error"? >=20 > Yes, Eric told me that we should start the error message with lover cas= e > and also we shouldn't print '.' at the end of the error message. More precisely, I pointed to 'git grep' results that proved that the code base overwhelmingly avoids trailing '.', but that it was rather ambiguous on whether messages start with a capital or a lower case. Changing the period was important, changing the capitalization feels a bit like churn unless we set a coding standard in HACKING telling which way new code should use. I can live with the churn in this commit as long as you are changing other things in the same hunk at the same time, but I wasn't specifically asking for capitalization changes. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2DTGSXJLMCXENAWGQTSRQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRZVXgAAoJEKeha0olJ0NqTJoIAI+2cixSM7iUvf39deeIu3Qd x5Z5gEJTbcBQxkEriXvNuE+Cn8LeGydH2cKbbFtxfwaLK3aSgECbVNRi6Bi76szA 9zeD2SY97lklxlXmoBctPQFiz9jLZ6QACbg25DKT0tv7u5t5LgxyoxTpEc6hpf+p ij48J53xT8K4lw2fq2zo0ImRTkP5fya8w6qpnAxu4LjOY2YJXbHjPlG7fQwRH7C3 7jcYiPLkdL7g/2/aOSlk352uXVyb0ltlpoYzMzz17y2wYtPPklNUinLE1Qod1rYp U9qXC5tMkOTWZp7SlpyzmmwThELmx4GZMM0yenQtsLNi4xL/HR4xf6sEQTY+YGs= =Qtr6 -----END PGP SIGNATURE----- ------enig2DTGSXJLMCXENAWGQTSRQ--