Re: [Qemu-devel] [PATCH v4 0/5] usb: QOM realize support for SysBus EHCI and FUSBH200

Re: [Qemu-devel] [PATCH v4 0/5] usb: QOM realize support for SysBus EHCI and FUSBH200

[Andreas Färber]

Am 25.02.2013 18:06, schrieb Andreas Färber:
> Hello Gerd,
> 
> v4 fixes the bus naming by leaving usb_bus_new() in realize for now.
> A mid-term fix will be to rework (q)bus initialization.

Ping?

> 
> Regards,
> Andreas
> 
> v3 -> v4:
> * Reverted moving usb_bus_new() into instance_init.
> 
> v1 -> v3:
> * Renamed realizefn -> realize following a discussion with Anthony.
> * Rename usb_ehci_initfn -> usb_ehci_realize.
> * Split off instance_init from initfn / realize, with Faraday in mind.
> * Incorporated Kuo-Jung's v1 EHCI refactoring + FUSBH200 EHCI.
> * Merged Kuo-Jung's v2 PCI initialization.
> 
> From Kuo-Jung's FUSBH200/PORTSC v1/v2:
> * Moved old portscbase and portnr values into base class_init.
> * Moved mem_vendor field to new FUSBH200EHCIState.
> * Replace vendor init callback with derived instance_init.
> * Introduced enum for vendor registers.
> * Replace magic number 0x34 with formula, so that it doesn't deviate.
> 
> From my Tegra2 FYI patch:
> * None.
> 
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Kuo-Jung Su <dantesu@faraday-tech.com>
> Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> Cc: Igor Mitsyanko <i.mitsyanko@samsung.com>
> Cc: Liming Wang <walimisdev@gmail.com>
> 
> Andreas Färber (3):
>   usb/hcd-ehci-sysbus: Convert to QOM realize
>   usb/hcd-ehci: Split off instance_init from realize
>   usb/hcd-ehci: Add Tegra2 SysBus EHCI device
> 
> Kuo-Jung Su (2):
>   usb/hcd-ehci: Replace PORTSC macros with variables
>   usb/hcd-ehci: Add Faraday FUSBH200 support
> 
>  hw/usb/hcd-ehci-pci.c    |   23 ++++++---
>  hw/usb/hcd-ehci-sysbus.c |  121 +++++++++++++++++++++++++++++++++++++++++++---
>  hw/usb/hcd-ehci.c        |   50 +++++++++++--------
>  hw/usb/hcd-ehci.h        |   28 ++++++++---
>  4 Dateien geändert, 181 Zeilen hinzugefügt(+), 41 Zeilen entfernt(-)
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH v4 0/5] usb: QOM realize support for SysBus EHCI and FUSBH200

[Gerd Hoffmann]

On 04/10/13 14:31, Andreas Färber wrote:
> Am 25.02.2013 18:06, schrieb Andreas Färber:
>> Hello Gerd,
>>
>> v4 fixes the bus naming by leaving usb_bus_new() in realize for now.
>> A mid-term fix will be to rework (q)bus initialization.
> 
> Ping?

Can you resend please?  /me finds only patches 1-3 in my qemu-devel
folder.  Sorry for the delay, somehow missed the series.

thanks,
  Gerd