From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPuWl-00064f-0x for qemu-devel@nongnu.org; Wed, 10 Apr 2013 08:53:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPuWj-0002ip-Qb for qemu-devel@nongnu.org; Wed, 10 Apr 2013 08:53:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPuWj-0002ik-HS for qemu-devel@nongnu.org; Wed, 10 Apr 2013 08:53:25 -0400 Message-ID: <516560B7.5020807@redhat.com> Date: Wed, 10 Apr 2013 14:53:11 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1365420597-5506-1-git-send-email-pbonzini@redhat.com> <3353B972624C8B49AB43F74428B4701D40ADE2F3@SZXEML552-MBS.china.huawei.com> In-Reply-To: <3353B972624C8B49AB43F74428B4701D40ADE2F3@SZXEML552-MBS.china.huawei.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/4] QEMUFile improvements and simplifications List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Liuji (Jeremy)" Cc: "kwolf@redhat.com" , "Luohao (brian)" , "quintela@redhat.com" , "qemu-devel@nongnu.org" , "owasserm@redhat.com" , Haofeng Il 10/04/2013 14:48, Liuji (Jeremy) ha scritto: > Hi, Paolo >=20 > I tested your 4 patches in the latest version of qemu.git/master(commit= : > 93b48c201eb6c0404d15550a0eaa3c0f7937e35e,2013-04-09). > These patches resolve the "savevm hanging" problem, which is detailedly= described > in my preceding mail:"After executing "savevm", the QEMU process is han= ging". >=20 > But, I found two other problem: > 1=A1=A2My VM's OS is winxp. After the execution of "savevm" is complete= d, I exec "loadvm". > But the winxp change to "blue screen", and then restart. I tested 3 tim= es, but the results are same. Does it work with commit 5cc11c46cf187c7d5306b68e730ec0d372cd7ef0? > 2=A1=A2The block migration is not OK. The qemu-system-x86_64 process of= source host is core-dump. > In the latest version of qemu.git/master(commit:93b48c201eb6c0404d15550= a0eaa3c0f7937e35e,2013-04-09),=20 > the block migration is OK. This is a simple division by zero. Juan, can you look at it? Paolo >=20 > The info of core-dump file: > #0 0x00007f8a44cec341 in migration_thread (opaque=3D0x7f8a45259bc0) at= migration.c:545 > 545 double bandwidth =3D transferred_bytes / time_spent; > (gdb) bt > #0 0x00007f8a44cec341 in migration_thread (opaque=3D0x7f8a45259bc0) at= migration.c:545 > #1 0x00007f8a42fb7d14 in ?? () > #2 0x0000000000000000 in ?? () >=20 >=20 >=20 > Best Regards, >=20 > Jeremy Liu >=20 >=20 >> This fixes Kevin's reported regression with savevm, and simplifies the >> QEMUFile code further. >> >> Patch 2 could be made a bit smaller at the expense of fixing the >> regression in the last patch only. I prefer to fix the bug earlier. >> >> Tested with Autotest. >> >> Paolo Bonzini (4): >> migration: set f->is_write and flush in add_to_iovec >> migration: use a single I/O operation when writev_buffer is not defi= ned >> migration: drop is_write complications >> migration: simplify writev vs. non-writev logic >> >> savevm.c | 104 ++++++++++++++++++++++++++----------------------------= --------- >> 1 file changed, 42 insertions(+), 62 deletions(-) >> >> -- >> 1.8.2 >> >=20