From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Corey Bryant <coreyb@linux.vnet.ibm.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Move TPM passthrough specific command line options to backend structure
Date: Wed, 10 Apr 2013 17:06:14 -0400 [thread overview]
Message-ID: <5165D446.7030109@linux.vnet.ibm.com> (raw)
In-Reply-To: <5165B4B1.2020003@linux.vnet.ibm.com>
On 04/10/2013 02:51 PM, Corey Bryant wrote:
>
>
> On 04/02/2013 01:30 PM, Stefan Berger wrote:
>> return 1;
>> }
>>
>> + /* validate backend specific opts */
>> + qemu_opts_validate(opts, be->opts, &errp);
>> + if (error_is_set(&errp)) {
>> + qerror_report_err(errp);
>> + error_free(errp);
>> + return 1;
>> + }
>> +
>
> This looks fine to me but I see this is the first call to
> qemu_opts_validate() in QEMU. I wonder why.
Well, the function does what is needed here, sorting out command line
parameters that are unknown. It also fits the available parameters.
I fixed the code related to the other comments. Thanks for the review.
Stefan
I
prev parent reply other threads:[~2013-04-10 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 17:30 [Qemu-devel] [PATCH] Move TPM passthrough specific command line options to backend structure Stefan Berger
2013-04-10 18:51 ` Corey Bryant
2013-04-10 21:06 ` Stefan Berger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5165D446.7030109@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).