From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40873)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1UQ2Du-0000PD-FM
	for qemu-devel@nongnu.org; Wed, 10 Apr 2013 17:06:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1UQ2Dq-0003ER-Ld
	for qemu-devel@nongnu.org; Wed, 10 Apr 2013 17:06:30 -0400
Received: from e7.ny.us.ibm.com ([32.97.182.137]:60157)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1UQ2Dq-0003CW-Ie
	for qemu-devel@nongnu.org; Wed, 10 Apr 2013 17:06:26 -0400
Received: from /spool/local
	by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <stefanb@linux.vnet.ibm.com>;
	Wed, 10 Apr 2013 17:06:17 -0400
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 8A537C9001E
	for <qemu-devel@nongnu.org>; Wed, 10 Apr 2013 17:06:15 -0400 (EDT)
Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r3AL6Ekv204184
	for <qemu-devel@nongnu.org>; Wed, 10 Apr 2013 17:06:15 -0400
Received: from d01av05.pok.ibm.com (loopback [127.0.0.1])
	by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	r3AL6E42005299
	for <qemu-devel@nongnu.org>; Wed, 10 Apr 2013 17:06:14 -0400
Message-ID: <5165D446.7030109@linux.vnet.ibm.com>
Date: Wed, 10 Apr 2013 17:06:14 -0400
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1364923843.339.2.camel@d941e-10>
	<5165B4B1.2020003@linux.vnet.ibm.com>
In-Reply-To: <5165B4B1.2020003@linux.vnet.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Move TPM passthrough specific command line
 options to backend structure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Corey Bryant <coreyb@linux.vnet.ibm.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 04/10/2013 02:51 PM, Corey Bryant wrote:
>
>
> On 04/02/2013 01:30 PM, Stefan Berger wrote:
>>           return 1;
>>       }
>>
>> +    /* validate backend specific opts */
>> +    qemu_opts_validate(opts, be->opts, &errp);
>> +    if (error_is_set(&errp)) {
>> +        qerror_report_err(errp);
>> +        error_free(errp);
>> +        return 1;
>> +    }
>> +
>
> This looks fine to me but I see this is the first call to 
> qemu_opts_validate() in QEMU.  I wonder why.

Well, the function does what is needed here, sorting out command line 
parameters that are unknown. It also fits the available parameters.

I fixed the code related to the other comments. Thanks for the review.

    Stefan
I