From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQ7DR-0005ja-T4 for qemu-devel@nongnu.org; Wed, 10 Apr 2013 22:26:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQ7DQ-0001YV-Ux for qemu-devel@nongnu.org; Wed, 10 Apr 2013 22:26:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQ7DQ-0001YM-LK for qemu-devel@nongnu.org; Wed, 10 Apr 2013 22:26:20 -0400 Message-ID: <51661F48.3070303@redhat.com> Date: Wed, 10 Apr 2013 20:26:16 -0600 From: Eric Blake MIME-Version: 1.0 References: <1365632901-15470-1-git-send-email-mrhines@linux.vnet.ibm.com> <1365632901-15470-11-git-send-email-mrhines@linux.vnet.ibm.com> In-Reply-To: <1365632901-15470-11-git-send-email-mrhines@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2EBSAAAWBFSJNRLVBXJPB" Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrhines@linux.vnet.ibm.com Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2EBSAAAWBFSJNRLVBXJPB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/10/2013 04:28 PM, mrhines@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" >=20 > This allows the user to disable zero page checking during migration >=20 > Signed-off-by: Michael R. Hines > --- > +++ b/qapi-schema.json > @@ -1792,6 +1792,19 @@ > { 'command': 'migrate_set_downtime', 'data': {'value': 'number'} } > =20 > ## > +# @migrate_check_for_zero > +# > +# Control whether or not to check for zero pages during migration. New QMP commands should be named with '-' rather than '_', as in 'migrate-check-for-zero'. Why do we need a new command, instead of adding a new capability to the already-existing capability command? > +# > +# @value: on|off=20 > +# > +# Returns: nothing on success > +# > +# Since: 1.5.0 > +## > +{ 'command': 'migrate_check_for_zero', 'data': {'value': 'bool'} } You can set the capability, but how do you query its current setting? I dislike write-only interfaces. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2EBSAAAWBFSJNRLVBXJPB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRZh9IAAoJEKeha0olJ0NqnWIIAINK2RqqkcRDyXcbQeJLH62W 3YoorYunESrMcFPH7Ymlr96bsbVIpCBcvZIbRbjzt8ibH+BUoZiiQ2qhGQtuBmnl oir2gOACMfp1lDM2kLVwycF+QWpuWdSuuo6jgx11qJMablh0GvDnI7pOx+orHE4w a7ExTUeenZj23KXUPHzID9Cs4U/SXS8HC+htbLwNysfRrSCoR0EAHQYbHxCKdFHv m/2vYA1AuetGoMTAhFeSMTZLUUBOzgshVKHNStNuDBK/3iNNn94X3/vKouYcjKVe bXRT13vHlyoQoltVNAZijhXxqrF74FaS8W7GM3/PN8C8NZeQxT4WAz8YCBC5S50= =BH1k -----END PGP SIGNATURE----- ------enig2EBSAAAWBFSJNRLVBXJPB--