From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQ7QL-0001VO-MS for qemu-devel@nongnu.org; Wed, 10 Apr 2013 22:39:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQ7QJ-0005gm-9M for qemu-devel@nongnu.org; Wed, 10 Apr 2013 22:39:41 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:48832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQ7QJ-0005gf-3D for qemu-devel@nongnu.org; Wed, 10 Apr 2013 22:39:39 -0400 Received: from /spool/local by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 10 Apr 2013 20:39:38 -0600 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id EA5823E4003E for ; Wed, 10 Apr 2013 20:39:22 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3B2dZFS141726 for ; Wed, 10 Apr 2013 20:39:35 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3B2dZMS001613 for ; Wed, 10 Apr 2013 20:39:35 -0600 Message-ID: <51662266.3040404@linux.vnet.ibm.com> Date: Wed, 10 Apr 2013 22:39:34 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1365632901-15470-1-git-send-email-mrhines@linux.vnet.ibm.com> <1365632901-15470-8-git-send-email-mrhines@linux.vnet.ibm.com> <51661EC4.1090207@redhat.com> In-Reply-To: <51661EC4.1090207@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v1: 07/13] introduce capability for dynamic chunk registration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com Acknowledged. On 04/10/2013 10:24 PM, Eric Blake wrote: > On 04/10/2013 04:28 PM, mrhines@linux.vnet.ibm.com wrote: >> From: "Michael R. Hines" >> >> This capability allows you to disable dynamic chunk registration >> for better throughput on high-performance links. >> >> It is enabled by default. > Actually, it isn't enabled until 8/13 - I'd squash 7 and 8 together, to > make this statement true. > >> +++ b/qapi-schema.json >> @@ -602,7 +602,7 @@ >> # Since: 1.2 > Missing documentation of the new capability. Should look something like: > > # @chunk-register-destination: Migration does XYZ on the destination. > # Enabled by default (since 1.5) > >> ## >> { 'enum': 'MigrationCapability', >> - 'data': ['xbzrle'] } >> + 'data': ['xbzrle', 'chunk_register_destination'] } > QMP prefers '-' over '_'/ >