From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQAbh-0005vh-CF for qemu-devel@nongnu.org; Thu, 11 Apr 2013 02:03:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQAbg-0006zE-7V for qemu-devel@nongnu.org; Thu, 11 Apr 2013 02:03:37 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:38484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQAbf-0006yg-I8 for qemu-devel@nongnu.org; Thu, 11 Apr 2013 02:03:36 -0400 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 11 Apr 2013 11:28:47 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id EBCFA1258051 for ; Thu, 11 Apr 2013 11:34:56 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3B63Npk8061416 for ; Thu, 11 Apr 2013 11:33:25 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3B63SKb025695 for ; Thu, 11 Apr 2013 16:03:28 +1000 Message-ID: <5166521E.8060201@linux.vnet.ibm.com> Date: Thu, 11 Apr 2013 14:03:10 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1364903250-10429-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1364903250-10429-10-git-send-email-xiawenc@linux.vnet.ibm.com> <878v4qxu1z.fsf@blackfin.pond.sub.org> In-Reply-To: <878v4qxu1z.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, stefanha@gmail.com, pbonzini@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com >> # Statistics of a virtual block device or a block backing device. >> diff --git a/qmp-commands.hx b/qmp-commands.hx >> index 1e0e11e..6b20684 100644 >> --- a/qmp-commands.hx >> +++ b/qmp-commands.hx >> @@ -1765,6 +1765,61 @@ EQMP >> }, >> >> SQMP >> +query-snapshots >> +--------------- >> + >> +Show the internal consistent snapshot information >> + >> +Each snapshot is represented by a json-object. The returned value >> +is a json-array of all snapshots >> + >> +Each json-object contain the following: >> + >> +- "id": unique snapshot id (json-string) >> +- "name": internal snapshot name (json-string) >> +- "vm-state-size": size of the VM state in bytes (json-int) >> +- "date-sec": UTC date of the snapshot in seconds (json-int) >> +- "date-nsec": fractional part in nanoseconds to be used with >> + date-sec(json-int) >> +- "vm-clock-sec": VM clock relative to boot in seconds (json-int) >> +- "vm-clock-nsec": fractional part in nanoseconds to be used with >> + vm-clock-sec (json-int) >> + >> +Example: >> + >> +-> { "execute": "query-snapshots" } >> +<- { >> + "return":[ >> + { >> + "id": "1", >> + "name": "snapshot1", >> + "vm-state-size": 0, >> + "date-sec": 10000200, >> + "date-nsec": 12, >> + "vm-clock-sec": 206, >> + "vm-clock-nsec": 30 > > Not your patch's fault, but here goes anyway: I dislike this > representation of time. > > QMP has time in seconds, milliseconds, nanoseconds, (seconds, > milliseconds) and (seconds, nanoseconds). There has been no adult > supervision, obviously (I may say that, because it's as much my fault as > it's anybody else's). > > The sanest one by far is nanoseconds. Good for 2^63 of them. Since pi > seconds is a nanocentury, good for 2^63 / (pi * 1e9) centuries, which > should be safely beyond your retirement age. > OK, will insert a patch before removing "vm-clock-sec". Have one question: how to declare uint64_t in qmp-schema.json? >> + }, >> + { >> + "id": "2", >> + "name": "snapshot2", >> + "vm-state-size": 34000000, >> + "date-sec": 13000200, >> + "date-nsec": 32, >> + "vm-clock-sec": 406, >> + "vm-clock-nsec": 31 >> + } >> + ] >> + } >> + >> +EQMP >> + >> + { >> + .name = "query-snapshots", >> + .args_type = "", >> + .mhandler.cmd_new = qmp_marshal_input_query_snapshots, >> + }, >> + >> +SQMP >> query-blockstats >> ---------------- > -- Best Regards Wenchao Xia