Re: [Qemu-devel] [PATCH V11 11/17] qmp: add ImageInfo in BlockDeviceInfo used by query-block

[Wenchao Xia <xiawenc@linux.vnet.ibm.com>]

>>                  "bps_wr":0,
>>                  "iops":1000000,
>>                  "iops_rd":0,
>>                  "iops_wr":0,
>> +               "image":{
>> +                  "filename":"disks/test.img",
> 
> Please change to "disks/test.qcow2".  I don't want people to get the
> idea they should name their QCOW2 images .img.
> 
>> +                  "format":"qcow2",
> 
  OK.

> I wonder how inserted.file and inserted.drv are related to
> inserted.image.filename and inserted.image.format.  Redundant or not?
> Kevin?
> 
  From code, I think it is Redundant.

>> +                  "virtual-size":2048000,
>> +                  "backing_file":"base.img",
>> +                  "full-backing-filename":"disks/base.img",
>> +                  "backing-filename-format:"qcow2",
>> +                  "snapshots":[
>> +                     {
>> +                        "id": "1",
>> +                        "name": "snapshot1",
>> +                        "vm-state-size": 0,
>> +                        "date-sec": 10000200,
>> +                        "date-nsec": 12,
>> +                        "vm-clock-sec": 206,
>> +                        "vm-clock-nsec": 30
>> +                     }
>> +                  ],
>> +                  "backing-image":{
>> +                      "filename":"disks/base.img",
>> +                      "format":"qcow2",
> 
> And here I wonder how inserted.image.full-backing-filename and
> .backing-filename-format are related to
> inserted.image.backing-image.filename and .backing-image.format.  Kevin?
> 
  Different in source, inserted.image.* is what inserted.image tell,
inserted.image.backing-image.* is what inserted.image.backing-image
tell. Same for user, image.filename should be recommended to use.

>> +                      "virtual-size":2048000
>> +                  }
>> +               }
>>               },
>>               "type":"unknown"
>>            },
> 


-- 
Best Regards

Wenchao Xia