From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQAss-0004px-7P for qemu-devel@nongnu.org; Thu, 11 Apr 2013 02:21:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQAsr-0004M9-8q for qemu-devel@nongnu.org; Thu, 11 Apr 2013 02:21:22 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:59189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQAsq-0004Lg-H7 for qemu-devel@nongnu.org; Thu, 11 Apr 2013 02:21:21 -0400 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 11 Apr 2013 11:45:46 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 6C66B1258051 for ; Thu, 11 Apr 2013 11:52:39 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3B6LA2W11993396 for ; Thu, 11 Apr 2013 11:51:10 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3B6LDX1022948 for ; Thu, 11 Apr 2013 16:21:13 +1000 Message-ID: <51665623.9040909@linux.vnet.ibm.com> Date: Thu, 11 Apr 2013 14:20:19 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1364903250-10429-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1364903250-10429-12-git-send-email-xiawenc@linux.vnet.ibm.com> <87r4iiwduy.fsf@blackfin.pond.sub.org> In-Reply-To: <87r4iiwduy.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V11 11/17] qmp: add ImageInfo in BlockDeviceInfo used by query-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, stefanha@gmail.com, pbonzini@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com >> "bps_wr":0, >> "iops":1000000, >> "iops_rd":0, >> "iops_wr":0, >> + "image":{ >> + "filename":"disks/test.img", > > Please change to "disks/test.qcow2". I don't want people to get the > idea they should name their QCOW2 images .img. > >> + "format":"qcow2", > OK. > I wonder how inserted.file and inserted.drv are related to > inserted.image.filename and inserted.image.format. Redundant or not? > Kevin? > From code, I think it is Redundant. >> + "virtual-size":2048000, >> + "backing_file":"base.img", >> + "full-backing-filename":"disks/base.img", >> + "backing-filename-format:"qcow2", >> + "snapshots":[ >> + { >> + "id": "1", >> + "name": "snapshot1", >> + "vm-state-size": 0, >> + "date-sec": 10000200, >> + "date-nsec": 12, >> + "vm-clock-sec": 206, >> + "vm-clock-nsec": 30 >> + } >> + ], >> + "backing-image":{ >> + "filename":"disks/base.img", >> + "format":"qcow2", > > And here I wonder how inserted.image.full-backing-filename and > .backing-filename-format are related to > inserted.image.backing-image.filename and .backing-image.format. Kevin? > Different in source, inserted.image.* is what inserted.image tell, inserted.image.backing-image.* is what inserted.image.backing-image tell. Same for user, image.filename should be recommended to use. >> + "virtual-size":2048000 >> + } >> + } >> }, >> "type":"unknown" >> }, > -- Best Regards Wenchao Xia