From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQB26-0001ot-FX for qemu-devel@nongnu.org; Thu, 11 Apr 2013 02:30:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQB25-0007KN-B9 for qemu-devel@nongnu.org; Thu, 11 Apr 2013 02:30:54 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:43327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQB24-0007JV-10 for qemu-devel@nongnu.org; Thu, 11 Apr 2013 02:30:53 -0400 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 11 Apr 2013 11:56:02 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 19C5F394005B for ; Thu, 11 Apr 2013 12:00:44 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3B6UexH1966416 for ; Thu, 11 Apr 2013 12:00:40 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3B6Ug2W029058 for ; Thu, 11 Apr 2013 16:30:43 +1000 Message-ID: <51665879.2050906@linux.vnet.ibm.com> Date: Thu, 11 Apr 2013 14:30:17 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1364903250-10429-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1364903250-10429-13-git-send-email-xiawenc@linux.vnet.ibm.com> <87sj2ytjpb.fsf@blackfin.pond.sub.org> In-Reply-To: <87sj2ytjpb.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V11 12/17] block: move bdrv_snapshot_dump() and dump_human_image_info() to block/qapi.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, stefanha@gmail.com, pbonzini@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com ÓÚ 2013-4-11 0:49, Markus Armbruster дµÀ: > Wenchao Xia writes: > >> They are needed later in hmp command, dump_human_image_info() >> is renamed to bdrv_image_info_dump(). >> >> Signed-off-by: Wenchao Xia > > I'd be tempted move everything that needs to move to block/qapi.c in one > go. > That is quite a lot of rebasing, and this patch shows tight relation with following patch(for hmp only), could it be kept as what it is? -- Best Regards Wenchao Xia