From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQCIi-0006nO-RP for qemu-devel@nongnu.org; Thu, 11 Apr 2013 03:52:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQCIh-0000s6-6D for qemu-devel@nongnu.org; Thu, 11 Apr 2013 03:52:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQCIg-0000rr-VF for qemu-devel@nongnu.org; Thu, 11 Apr 2013 03:52:07 -0400 Message-ID: <51666BB2.80508@redhat.com> Date: Thu, 11 Apr 2013 10:52:18 +0300 From: Orit Wasserman MIME-Version: 1.0 References: <1365632901-15470-1-git-send-email-mrhines@linux.vnet.ibm.com> <1365632901-15470-11-git-send-email-mrhines@linux.vnet.ibm.com> <51661F48.3070303@redhat.com> <51662249.20205@linux.vnet.ibm.com> In-Reply-To: <51662249.20205@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael R. Hines" Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com On 04/11/2013 05:39 AM, Michael R. Hines wrote: > On 04/10/2013 10:26 PM, Eric Blake wrote: >> >> New QMP commands should be named with '-' rather than '_', as in >> 'migrate-check-for-zero'. >> >> Why do we need a new command, instead of adding a new capability to the >> already-existing capability command? >> > > Orit told me to convert the capability to a command =) > (It was originally a capability) > > I prefer it a command because it is not related directly to RDMA I can see it used in regular live migration too. Orit