From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQEhv-000552-0b for qemu-devel@nongnu.org; Thu, 11 Apr 2013 06:26:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQEht-0001ZD-Ry for qemu-devel@nongnu.org; Thu, 11 Apr 2013 06:26:18 -0400 Received: from mail-bk0-x22f.google.com ([2a00:1450:4008:c01::22f]:44350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQEht-0001Z5-KG for qemu-devel@nongnu.org; Thu, 11 Apr 2013 06:26:17 -0400 Received: by mail-bk0-f47.google.com with SMTP id ik5so714668bkc.6 for ; Thu, 11 Apr 2013 03:26:16 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51668FC1.4050104@redhat.com> Date: Thu, 11 Apr 2013 12:26:09 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1364804434-7980-1-git-send-email-qemulist@gmail.com> <1364804434-7980-3-git-send-email-qemulist@gmail.com> <20130411101118.GC9165@stefanha-thinkpad.redhat.com> In-Reply-To: <20130411101118.GC9165@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/5] hostmem: make hostmem global and RAM hotunplg safe List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Peter Maydell , Anthony Liguori , Jan Kiszka , Marcelo Tosatti , qemu-devel@nongnu.org, Liu Ping Fan , Vasilis Liaskovitis Il 11/04/2013 12:11, Stefan Hajnoczi ha scritto: > Also, these sync gcc builtins are not available on all platforms or gcc > versions. We need to be a little careful to avoid breaking builds here. > Maybe __sync_add_and_fetch() is fine but I wanted to mention it because > I've had trouble with these in the past. We are already using GCC atomics elsewhere (spice, migration, vhost). They are really ugly to type and not complete, so we should have our own wrapper include, but they are fine. Paolo