From: Orit Wasserman <owasserm@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org,
"Michael R. Hines" <mrhines@linux.vnet.ibm.com>,
abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero
Date: Thu, 11 Apr 2013 15:36:45 +0300 [thread overview]
Message-ID: <5166AE5D.4060802@redhat.com> (raw)
In-Reply-To: <5166ACC8.90505@redhat.com>
On 04/11/2013 03:30 PM, Eric Blake wrote:
> On 04/11/2013 01:52 AM, Orit Wasserman wrote:
>> On 04/11/2013 05:39 AM, Michael R. Hines wrote:
>>> On 04/10/2013 10:26 PM, Eric Blake wrote:
>>>>
>>>> New QMP commands should be named with '-' rather than '_', as in
>>>> 'migrate-check-for-zero'.
>>>>
>>>> Why do we need a new command, instead of adding a new capability to the
>>>> already-existing capability command?
>>>>
>>>
>>> Orit told me to convert the capability to a command =)
>>> (It was originally a capability)
>>>
>>>
>> I prefer it a command because it is not related directly to RDMA I can
>> see it used in regular live migration too.
>
> But how is a new command any different than a new capability? Both can
> be used in regular live migration, and for all intents and purposes, it
> feels like a capability.
>
It has no meaning for incoming migration only for outgoing.
Anyway Paolo think it should not be needed so this patch will be removed.
Orit
next prev parent reply other threads:[~2013-04-11 12:35 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 22:28 [Qemu-devel] [RFC PATCH RDMA support v7: 00/13] rdma cleanup and reordering mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 01/13] introduce qemu_ram_foreach_block() mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 02/13] Core RMDA logic mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 03/13] RDMA is enabled by default per the usual ./configure testing mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 04/13] update QEMUFileOps with new hooks mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 05/13] accessor function prototypes for new QEMUFileOps hooks mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 06/13] implementation of " mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 07/13] introduce capability for dynamic chunk registration mrhines
2013-04-11 2:24 ` Eric Blake
2013-04-11 2:39 ` Michael R. Hines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 08/13] default chunk registration to true mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 09/13] parse QMP string for new 'rdma' protocol mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero mrhines
2013-04-11 2:26 ` Eric Blake
2013-04-11 2:39 ` Michael R. Hines
2013-04-11 7:52 ` Orit Wasserman
2013-04-11 12:30 ` Eric Blake
2013-04-11 12:36 ` Orit Wasserman [this message]
2013-04-11 17:53 ` Michael R. Hines
2013-04-11 3:11 ` Michael R. Hines
2013-04-11 7:38 ` Michael S. Tsirkin
2013-04-11 9:18 ` Paolo Bonzini
2013-04-11 11:13 ` Michael S. Tsirkin
2013-04-11 13:19 ` Michael R. Hines
2013-04-11 13:51 ` Michael S. Tsirkin
2013-04-11 14:06 ` Michael R. Hines
2013-04-11 14:17 ` Paolo Bonzini
2013-04-11 14:35 ` Michael R. Hines
2013-04-11 14:45 ` Paolo Bonzini
2013-04-11 15:37 ` Michael R. Hines
2013-04-11 13:24 ` Michael R. Hines
2013-04-11 14:15 ` Paolo Bonzini
2013-04-11 14:45 ` Michael S. Tsirkin
2013-04-11 14:57 ` Michael R. Hines
2013-04-11 15:01 ` Michael S. Tsirkin
2013-04-11 15:08 ` Paolo Bonzini
2013-04-11 15:35 ` Michael R. Hines
2013-04-11 15:45 ` Paolo Bonzini
2013-04-11 16:02 ` Michael R. Hines
2013-04-11 16:12 ` Paolo Bonzini
2013-04-11 16:07 ` Eric Blake
2013-04-11 16:29 ` Michael R. Hines
2013-04-11 16:36 ` Eric Blake
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 11/13] send pc.ram over RDMA mrhines
2013-04-11 6:26 ` Paolo Bonzini
2013-04-11 12:41 ` Michael R. Hines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 12/13] updated protocol documentation mrhines
2013-04-11 2:43 ` Eric Blake
2013-04-11 2:47 ` Michael R. Hines
2013-04-11 6:29 ` Paolo Bonzini
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 13/13] print out migration throughput while debugging mrhines
2013-04-10 22:32 ` [Qemu-devel] [RFC PATCH RDMA support v7: 00/13] rdma cleanup and reordering Michael R. Hines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5166AE5D.4060802@redhat.com \
--to=owasserm@redhat.com \
--cc=abali@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=eblake@redhat.com \
--cc=gokul@us.ibm.com \
--cc=mrhines@linux.vnet.ibm.com \
--cc=mrhines@us.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).