From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56107)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1UQGoa-0004D7-Im
	for qemu-devel@nongnu.org; Thu, 11 Apr 2013 08:41:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1UQGoX-0004rl-QQ
	for qemu-devel@nongnu.org; Thu, 11 Apr 2013 08:41:20 -0400
Received: from e7.ny.us.ibm.com ([32.97.182.137]:38790)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1UQGoX-0004rd-MI
	for qemu-devel@nongnu.org; Thu, 11 Apr 2013 08:41:17 -0400
Received: from /spool/local
	by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mrhines@linux.vnet.ibm.com>;
	Thu, 11 Apr 2013 08:41:15 -0400
Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235])
	by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 88D74C9001A
	for <qemu-devel@nongnu.org>; Thu, 11 Apr 2013 08:41:12 -0400 (EDT)
Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245])
	by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r3BCfCeO303820
	for <qemu-devel@nongnu.org>; Thu, 11 Apr 2013 08:41:12 -0400
Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1])
	by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id r3BChtZA008747
	for <qemu-devel@nongnu.org>; Thu, 11 Apr 2013 06:43:55 -0600
Message-ID: <5166AF63.9010303@linux.vnet.ibm.com>
Date: Thu, 11 Apr 2013 08:41:07 -0400
From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1365632901-15470-1-git-send-email-mrhines@linux.vnet.ibm.com>
	<1365632901-15470-12-git-send-email-mrhines@linux.vnet.ibm.com>
	<516657AC.1090408@redhat.com>
In-Reply-To: <516657AC.1090408@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v1: 11/13] send
 pc.ram	over RDMA
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com

Acknowledged.

On 04/11/2013 02:26 AM, Paolo Bonzini wrote:
> Il 11/04/2013 00:28, mrhines@linux.vnet.ibm.com ha scritto:
>>   
>> +#ifdef CONFIG_RDMA
>> +int qemu_rdma_registration_start(QEMUFile *f, void *opaque, uint32_t flags)
>> +{
>> +    DPRINTF("start section: %d\n", flags);
>> +    qemu_put_be64(f, RAM_SAVE_FLAG_HOOK);
>> +    return 0;
>> +}
>> +#endif
>>   
> This must be in migration-rdma.c.  Move RAM_SAVE_FLAG_HOOK to
> migration/migration.h with a comment like this:
>
> /* Whenever this is found in the data stream, the flags
>   * will be passed to ram_load_hook in the incoming-migration
>   * side.  This lets before_ram_iterate/after_ram_iterate add
>   * transport-specific sections to the RAM migration data.
>   */
>
> Paolo
>