From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com,
mrhines@us.ibm.com, gokul@us.ibm.com
Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero
Date: Thu, 11 Apr 2013 16:17:30 +0200 [thread overview]
Message-ID: <5166C5FA.1020009@redhat.com> (raw)
In-Reply-To: <5166C381.4030405@linux.vnet.ibm.com>
Il 11/04/2013 16:06, Michael R. Hines ha scritto:
>>>
>> My understanding is the issue is protocol compatibility,
>> not optimization. E.g. you can migrate to file, for each
>> new feature you need a way to disable it to stay compatible.
>
> Ok, understood.
>
> I would be happy to add a check for the other migration URI
> protocols (like 'unix', 'tcp', etc) which says rejects disabling
> the zero page checking only if the URI is for rdma.
>
> Would that be OK?
I would like to see is_dup_page() on top of a "perf" profile for a
real-world scenario, and throughput numbers for the same real-world
scenario with/without is_dup_page(). Once you show that, yes.
Paolo
next prev parent reply other threads:[~2013-04-11 14:23 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 22:28 [Qemu-devel] [RFC PATCH RDMA support v7: 00/13] rdma cleanup and reordering mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 01/13] introduce qemu_ram_foreach_block() mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 02/13] Core RMDA logic mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 03/13] RDMA is enabled by default per the usual ./configure testing mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 04/13] update QEMUFileOps with new hooks mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 05/13] accessor function prototypes for new QEMUFileOps hooks mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 06/13] implementation of " mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 07/13] introduce capability for dynamic chunk registration mrhines
2013-04-11 2:24 ` Eric Blake
2013-04-11 2:39 ` Michael R. Hines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 08/13] default chunk registration to true mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 09/13] parse QMP string for new 'rdma' protocol mrhines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero mrhines
2013-04-11 2:26 ` Eric Blake
2013-04-11 2:39 ` Michael R. Hines
2013-04-11 7:52 ` Orit Wasserman
2013-04-11 12:30 ` Eric Blake
2013-04-11 12:36 ` Orit Wasserman
2013-04-11 17:53 ` Michael R. Hines
2013-04-11 3:11 ` Michael R. Hines
2013-04-11 7:38 ` Michael S. Tsirkin
2013-04-11 9:18 ` Paolo Bonzini
2013-04-11 11:13 ` Michael S. Tsirkin
2013-04-11 13:19 ` Michael R. Hines
2013-04-11 13:51 ` Michael S. Tsirkin
2013-04-11 14:06 ` Michael R. Hines
2013-04-11 14:17 ` Paolo Bonzini [this message]
2013-04-11 14:35 ` Michael R. Hines
2013-04-11 14:45 ` Paolo Bonzini
2013-04-11 15:37 ` Michael R. Hines
2013-04-11 13:24 ` Michael R. Hines
2013-04-11 14:15 ` Paolo Bonzini
2013-04-11 14:45 ` Michael S. Tsirkin
2013-04-11 14:57 ` Michael R. Hines
2013-04-11 15:01 ` Michael S. Tsirkin
2013-04-11 15:08 ` Paolo Bonzini
2013-04-11 15:35 ` Michael R. Hines
2013-04-11 15:45 ` Paolo Bonzini
2013-04-11 16:02 ` Michael R. Hines
2013-04-11 16:12 ` Paolo Bonzini
2013-04-11 16:07 ` Eric Blake
2013-04-11 16:29 ` Michael R. Hines
2013-04-11 16:36 ` Eric Blake
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 11/13] send pc.ram over RDMA mrhines
2013-04-11 6:26 ` Paolo Bonzini
2013-04-11 12:41 ` Michael R. Hines
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 12/13] updated protocol documentation mrhines
2013-04-11 2:43 ` Eric Blake
2013-04-11 2:47 ` Michael R. Hines
2013-04-11 6:29 ` Paolo Bonzini
2013-04-10 22:28 ` [Qemu-devel] [RFC PATCH RDMA support v1: 13/13] print out migration throughput while debugging mrhines
2013-04-10 22:32 ` [Qemu-devel] [RFC PATCH RDMA support v7: 00/13] rdma cleanup and reordering Michael R. Hines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5166C5FA.1020009@redhat.com \
--to=pbonzini@redhat.com \
--cc=abali@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=gokul@us.ibm.com \
--cc=mrhines@linux.vnet.ibm.com \
--cc=mrhines@us.ibm.com \
--cc=mst@redhat.com \
--cc=owasserm@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).