From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59081)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UQIOx-0006Od-GN
	for qemu-devel@nongnu.org; Thu, 11 Apr 2013 10:23:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UQIOs-00043g-HG
	for qemu-devel@nongnu.org; Thu, 11 Apr 2013 10:22:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58517)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UQIOs-00043L-6t
	for qemu-devel@nongnu.org; Thu, 11 Apr 2013 10:22:54 -0400
Message-ID: <5166C5FA.1020009@redhat.com>
Date: Thu, 11 Apr 2013 16:17:30 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1365632901-15470-1-git-send-email-mrhines@linux.vnet.ibm.com>
	<1365632901-15470-11-git-send-email-mrhines@linux.vnet.ibm.com>
	<20130411073843.GB19601@redhat.com> <51667FEE.903@redhat.com>
	<20130411111329.GA21714@redhat.com>
	<5166B86F.1050504@linux.vnet.ibm.com>
	<20130411135121.GB24942@redhat.com>
	<5166C381.4030405@linux.vnet.ibm.com>
In-Reply-To: <5166C381.4030405@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new
 command migrate_check_for_zero
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com

Il 11/04/2013 16:06, Michael R. Hines ha scritto:
>>>
>> My understanding is the issue is protocol compatibility,
>> not optimization. E.g. you can migrate to file, for each
>> new feature you need a way to disable it to stay compatible.
> 
> Ok, understood.
> 
> I would be happy to add a check for the other migration URI
> protocols (like 'unix', 'tcp', etc) which says rejects disabling
> the zero page checking only if the URI is for rdma.
> 
> Would that be OK?

I would like to see is_dup_page() on top of a "perf" profile for a
real-world scenario, and throughput numbers for the same real-world
scenario with/without is_dup_page().  Once you show that, yes.

Paolo