From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQJWR-0005IW-IM for qemu-devel@nongnu.org; Thu, 11 Apr 2013 11:34:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQJWQ-00079K-G6 for qemu-devel@nongnu.org; Thu, 11 Apr 2013 11:34:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQJWQ-00079D-8U for qemu-devel@nongnu.org; Thu, 11 Apr 2013 11:34:46 -0400 Message-ID: <5166D7D5.8080403@redhat.com> Date: Thu, 11 Apr 2013 17:33:41 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20130410052714.GB12777@redhat.com> <5165636C.1090908@linux.vnet.ibm.com> <20130410133448.GA18128@redhat.com> <51658554.2000909@linux.vnet.ibm.com> <20130410174107.GB32247@redhat.com> <5165C60E.20006@linux.vnet.ibm.com> <20130411071927.GA17063@redhat.com> <5166B6B1.2030003@linux.vnet.ibm.com> <20130411134820.GA24942@redhat.com> <5166C19A.1040402@linux.vnet.ibm.com> <20130411143718.GC24942@redhat.com> <5166D460.2070106@linux.vnet.ibm.com> In-Reply-To: <5166D460.2070106@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael R. Hines" Cc: aliguori@us.ibm.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com Il 11/04/2013 17:18, Michael R. Hines ha scritto: > First of all, this whole argument should not even exist for the > following reason: > > Page registrations are supposed to be *rare* - once a page is > registered, it is registered for life. Uh-oh. That changes things a lot. We do not even need to benchmark the various chunk sizes. > Third, this means that optimizing this protocol would not be helpful > and that we should follow the "keep it simple" approach because > during steady-state phase of the migration most of the pages should > have already been registered. Ok, let's keep it simple. The only two things we need are: 1) remove the patch to disable is_dup_page 2) rename the transport to "x-rdma" (just in migration.c) Both things together let us keep it safe for a release or two. Let's merge this thing. Paolo