From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQJYu-0008Iw-1z for qemu-devel@nongnu.org; Thu, 11 Apr 2013 11:37:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQJYr-0008D4-76 for qemu-devel@nongnu.org; Thu, 11 Apr 2013 11:37:20 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:57372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQJYq-0008Cz-T6 for qemu-devel@nongnu.org; Thu, 11 Apr 2013 11:37:17 -0400 Received: from /spool/local by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 11 Apr 2013 09:37:15 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 3B2A31FF006B for ; Thu, 11 Apr 2013 09:32:11 -0600 (MDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3BFb3Po058492 for ; Thu, 11 Apr 2013 09:37:03 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3BFdnwd007054 for ; Thu, 11 Apr 2013 09:39:49 -0600 Message-ID: <5166D89D.6080904@linux.vnet.ibm.com> Date: Thu, 11 Apr 2013 11:37:01 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1365632901-15470-1-git-send-email-mrhines@linux.vnet.ibm.com> <1365632901-15470-11-git-send-email-mrhines@linux.vnet.ibm.com> <20130411073843.GB19601@redhat.com> <51667FEE.903@redhat.com> <20130411111329.GA21714@redhat.com> <5166B86F.1050504@linux.vnet.ibm.com> <20130411135121.GB24942@redhat.com> <5166C381.4030405@linux.vnet.ibm.com> <5166C5FA.1020009@redhat.com> <5166CA42.5050505@linux.vnet.ibm.com> <5166CC9A.2030505@redhat.com> In-Reply-To: <5166CC9A.2030505@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com On 04/11/2013 10:45 AM, Paolo Bonzini wrote: > > Right, but introducing new APIs is not free. > > Let's leave is_dup_page unconditionally in now. We can always remove it > later if it turns out to be useful. > > The important thing is to have the code in early to give it wider > exposure. Once it is in, people can test it more, benchmark > with/without is_dup_page, etc. We can declare it experimental, and > break the protocol later if it turns out to be bad. > > I think all that's needed is: > > 1) benchmark the various chunk sizes (with is_dup_page disabled and your > current stress test -- better than nothing). Please confirm that the > source can modify the chunk size and the destination will just pick it up. > > 2) remove the patch to disable is_dup_page > > 3) rename the transport to "x-rdma" (just in migration.c). > > And that's it. The patches should be ready. > > We have converged on a good interface between RDMA and the generic > migration code, and that's the important thing because later > implementations will not throw away that work. > > Paolo Ok, acknowledged =)