From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQJjH-0006nb-FE for qemu-devel@nongnu.org; Thu, 11 Apr 2013 11:48:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQJjF-0003by-Lu for qemu-devel@nongnu.org; Thu, 11 Apr 2013 11:48:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQJjF-0003bm-E1 for qemu-devel@nongnu.org; Thu, 11 Apr 2013 11:48:01 -0400 Message-ID: <5166DB29.5040101@redhat.com> Date: Thu, 11 Apr 2013 17:47:53 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <51658554.2000909@linux.vnet.ibm.com> <20130410174107.GB32247@redhat.com> <5165C60E.20006@linux.vnet.ibm.com> <20130411071927.GA17063@redhat.com> <5166B6B1.2030003@linux.vnet.ibm.com> <20130411134820.GA24942@redhat.com> <5166C19A.1040402@linux.vnet.ibm.com> <20130411143718.GC24942@redhat.com> <5166D460.2070106@linux.vnet.ibm.com> <5166D7D5.8080403@redhat.com> <20130411154639.GC22779@redhat.com> In-Reply-To: <20130411154639.GC22779@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, "Michael R. Hines" , owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com Il 11/04/2013 17:46, Michael S. Tsirkin ha scritto: > > Ok, let's keep it simple. The only two things we need are: > > > > 1) remove the patch to disable is_dup_page > > > > 2) rename the transport to "x-rdma" (just in migration.c) > > > > Both things together let us keep it safe for a release or two. Let's > > merge this thing. > > I would drop the chunk based thing too. Besides being slow, it turns > out that it pins all memory anyway. So no memory overcommit. It doesn't pin zero pages. Those are never transmitted (it's a recent change). So pages that are ballooned at the beginning of migration, and remain ballooned throughout, will never be pinned. Paolo