From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQKsS-0003fk-Gg for qemu-devel@nongnu.org; Thu, 11 Apr 2013 13:01:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQKsP-00059D-Qe for qemu-devel@nongnu.org; Thu, 11 Apr 2013 13:01:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQKsP-000597-JS for qemu-devel@nongnu.org; Thu, 11 Apr 2013 13:01:33 -0400 Message-ID: <5166ECF0.50003@redhat.com> Date: Thu, 11 Apr 2013 19:03:44 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1365696441-10696-1-git-send-email-armbru@redhat.com> In-Reply-To: <1365696441-10696-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] Fix JSON string formatter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: blauwirbel@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org On 04/11/13 18:07, Markus Armbruster wrote: > This should unbreak "make check" on machines where char is unsigned. > Blue, please give it a whirl. > > The JSON parser is still as broken as ever. Left for another day. > > v2: > - Rebased, trivial conflicts in PATCH 1/4. > - Make mod_utf8_codepoint() treat empty input as invalid sequence of > length zero (both when n==0 and when n>0 && *s==0). No code in this > series passes empty input. > - Some commit messages and comments improved. > > Markus Armbruster (4): > unicode: New mod_utf8_codepoint() > check-qjson: Improve a few comments, delete bogus ones > check-qjson: Test noncharacters other than U+FFFE, U+FFFF in strings > qjson: to_json() case QTYPE_QSTRING is buggy, rewrite > > include/qemu-common.h | 3 + > qobject/qjson.c | 102 ++++++++--------- > tests/check-qjson.c | 308 ++++++++++++++++++++++++++++++-------------------- > util/Makefile.objs | 2 +- > util/unicode.c | 100 ++++++++++++++++ > 5 files changed, 333 insertions(+), 182 deletions(-) > create mode 100644 util/unicode.c > I compared this v2 series patch-wise to v1. Reviewed-by: Laszlo Ersek