From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQLhH-0007Zw-8A for qemu-devel@nongnu.org; Thu, 11 Apr 2013 13:54:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQLhE-00073v-I7 for qemu-devel@nongnu.org; Thu, 11 Apr 2013 13:54:07 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:35608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQLhE-000728-EN for qemu-devel@nongnu.org; Thu, 11 Apr 2013 13:54:04 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 11 Apr 2013 13:54:02 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 73D826E807B for ; Thu, 11 Apr 2013 13:53:56 -0400 (EDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3BHrw7L314218 for ; Thu, 11 Apr 2013 13:53:58 -0400 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3BHrsAe009015 for ; Thu, 11 Apr 2013 11:53:54 -0600 Message-ID: <5166F8B0.6070408@linux.vnet.ibm.com> Date: Thu, 11 Apr 2013 13:53:52 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1365632901-15470-1-git-send-email-mrhines@linux.vnet.ibm.com> <1365632901-15470-11-git-send-email-mrhines@linux.vnet.ibm.com> <51661F48.3070303@redhat.com> <51662249.20205@linux.vnet.ibm.com> <51666BB2.80508@redhat.com> <5166ACC8.90505@redhat.com> <5166AE5D.4060802@redhat.com> In-Reply-To: <5166AE5D.4060802@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com On 04/11/2013 08:36 AM, Orit Wasserman wrote: > On 04/11/2013 03:30 PM, Eric Blake wrote: >> On 04/11/2013 01:52 AM, Orit Wasserman wrote: >>> On 04/11/2013 05:39 AM, Michael R. Hines wrote: >>>> On 04/10/2013 10:26 PM, Eric Blake wrote: >>>>> New QMP commands should be named with '-' rather than '_', as in >>>>> 'migrate-check-for-zero'. >>>>> >>>>> Why do we need a new command, instead of adding a new capability to the >>>>> already-existing capability command? >>>>> >>>> Orit told me to convert the capability to a command =) >>>> (It was originally a capability) >>>> >>>> >>> I prefer it a command because it is not related directly to RDMA I can >>> see it used in regular live migration too. >> But how is a new command any different than a new capability? Both can >> be used in regular live migration, and for all intents and purposes, it >> feels like a capability. >> > It has no meaning for incoming migration only for outgoing. > Anyway Paolo think it should not be needed so this patch will be removed. > > Orit > Yes, I will delete the command altogether. - Michael