From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQUZ5-0004J9-2d for qemu-devel@nongnu.org; Thu, 11 Apr 2013 23:22:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQUZ3-0001Mr-Ly for qemu-devel@nongnu.org; Thu, 11 Apr 2013 23:22:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQUZ3-0001Md-DJ for qemu-devel@nongnu.org; Thu, 11 Apr 2013 23:22:13 -0400 Message-ID: <51677DDE.6000703@redhat.com> Date: Thu, 11 Apr 2013 21:22:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <1364903250-10429-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1364903250-10429-10-git-send-email-xiawenc@linux.vnet.ibm.com> <878v4qxu1z.fsf@blackfin.pond.sub.org> <5166521E.8060201@linux.vnet.ibm.com> <87bo9lfes4.fsf@blackfin.pond.sub.org> <20130411084401.47405e80@redhat.com> <5166B5D9.1010906@redhat.com> <20130411093914.24941714@redhat.com> <51677CAE.5090805@linux.vnet.ibm.com> In-Reply-To: <51677CAE.5090805@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2QVOCESSOWSBVALNITONK" Subject: Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, Markus Armbruster , pbonzini@redhat.com, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2QVOCESSOWSBVALNITONK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/11/2013 09:17 PM, Wenchao Xia wrote: >> >>> Hmm, as I typed that, I did another search of qemu-schema.json - we h= ave >>> the type 'ImageInfo' defined, but none of the existing 'command's eve= r >>> call out the use of that type. Is it a type we are only using >>> internally to date, and where this is the first QMP command that woul= d >>> actually expose SnapshotInfo or ImageInfo to a management app? Then >>> maybe we _CAN_ modify SnapshotInfo, clean up all the internal code, a= nd >>> provide a saner type for the first time that QMP can actually use it.= >> >> IIRC, it's being used by qemu-img. As it's not trivial to determine if= >> the field has users and as what goes in the schema is to be considered= >> stable, >> it's better to keep the field. Instead, we could add a better field an= d >> deprecate the current one. >> > I remember there is a patch laster year made "qemu-img info" dump out= > json strings, where vm-clock-sec is dumped out. Ah, so it's not QMP exposing it, but qemu-info in JSON mode. Still, changing that output to delete a field might break existing tools; adding a field might be safer, but then you'd have redundant information in the old style for old tools, as well as the added field. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2QVOCESSOWSBVALNITONK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRZ33eAAoJEKeha0olJ0NqqpEH+wUoXUonqj3Wc3xUw7fKxaf4 bc7Fv6Nek7SP7wB48NT006fy9aZyzhjvDgjSBPHQZNzLAzjzqRL7Ur0BBDOP/aZd G225oFcofz9RYkgO/eweIDyaE0OQwzKQAH/7+Wf+QU934BAGKSc/wH/7h+MNzowj bZCeg8PS72mIFrt8BTYilc79Dezn51ZFUvJl6aIj5A6troEouxuBJFLaQzzcx3wu KPFE+pRMnKb9y4WHC5mk/WtvFHu6ORcmcL2q7h2Kdx6hn7sTnexWSOLDd6eutWMp mZn7PCRUoI5Cm0Ocgq5kwfgzzemVFj1ISC2jcrrVYtuqRzhtusojydErQNYvD/g= =dxXt -----END PGP SIGNATURE----- ------enig2QVOCESSOWSBVALNITONK--