qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "KONRAD Frédéric" <fred.konrad@greensocs.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, mark.burton@greensocs.com,
	qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>,
	cornelia.huck@de.ibm.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH] virtio-balloon: fix dynamic properties.
Date: Fri, 12 Apr 2013 10:36:27 +0200	[thread overview]
Message-ID: <5167C78B.3060405@greensocs.com> (raw)
In-Reply-To: <CAFEAcA87uvigL4cE+vVDJj=T453YDXC=keLBs8VL8xfS5BVBOQ@mail.gmail.com>

On 12/04/2013 10:29, Peter Maydell wrote:
> On 11 April 2013 23:38,  <fred.konrad@greensocs.com> wrote:
>> From: KONRAD Frederic <fred.konrad@greensocs.com>
>>
>> To keep compatibility with the old virtio-balloon-x, add the dynamic properties
>> to virtio-balloon-pci and virtio-balloon-ccw.
> Does the approach I suggested on IRC where virtio-balloon-pci's
> property set/get callbacks just set/get the property on
> virtio-balloon via the public interface not work? Having to
> expose virtio-balloon's callback functions seems a bit of
> an encapsulation violation...
>
> thanks
> -- PMM
Oh, I didn't understand that like that.

What do you mean by the public interface?

I thought you wanted two set/get callbacks which call directly 
virtio-balloon callbacks.

Thanks,
Fred

  reply	other threads:[~2013-04-12  8:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-11 22:38 [Qemu-devel] [PATCH] virtio-balloon: fix dynamic properties fred.konrad
2013-04-12  8:29 ` Peter Maydell
2013-04-12  8:36   ` KONRAD Frédéric [this message]
2013-04-12  9:14     ` Peter Maydell
2013-04-12  9:19       ` KONRAD Frédéric
2013-04-12  9:33       ` KONRAD Frédéric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5167C78B.3060405@greensocs.com \
    --to=fred.konrad@greensocs.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=lcapitulino@redhat.com \
    --cc=mark.burton@greensocs.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).