From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQZTF-00067v-Nz for qemu-devel@nongnu.org; Fri, 12 Apr 2013 04:36:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQZTE-0003xJ-Pw for qemu-devel@nongnu.org; Fri, 12 Apr 2013 04:36:33 -0400 Received: from greensocs.com ([87.106.252.221]:53200 helo=s15328186.onlinehome-server.info) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQZTE-0003x9-JV for qemu-devel@nongnu.org; Fri, 12 Apr 2013 04:36:32 -0400 Message-ID: <5167C78B.3060405@greensocs.com> Date: Fri, 12 Apr 2013 10:36:27 +0200 From: =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= MIME-Version: 1.0 References: <1365719939-7169-1-git-send-email-fred.konrad@greensocs.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-balloon: fix dynamic properties. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, Luiz Capitulino , cornelia.huck@de.ibm.com, afaerber@suse.de On 12/04/2013 10:29, Peter Maydell wrote: > On 11 April 2013 23:38, wrote: >> From: KONRAD Frederic >> >> To keep compatibility with the old virtio-balloon-x, add the dynamic properties >> to virtio-balloon-pci and virtio-balloon-ccw. > Does the approach I suggested on IRC where virtio-balloon-pci's > property set/get callbacks just set/get the property on > virtio-balloon via the public interface not work? Having to > expose virtio-balloon's callback functions seems a bit of > an encapsulation violation... > > thanks > -- PMM Oh, I didn't understand that like that. What do you mean by the public interface? I thought you wanted two set/get callbacks which call directly virtio-balloon callbacks. Thanks, Fred