From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQaVA-0002Xn-1P for qemu-devel@nongnu.org; Fri, 12 Apr 2013 05:42:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQaV9-0002i5-2H for qemu-devel@nongnu.org; Fri, 12 Apr 2013 05:42:35 -0400 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:53958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQaV8-0002hb-53 for qemu-devel@nongnu.org; Fri, 12 Apr 2013 05:42:34 -0400 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 12 Apr 2013 19:35:03 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 6592F2CE804C for ; Fri, 12 Apr 2013 19:42:10 +1000 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3C9SnY810748344 for ; Fri, 12 Apr 2013 19:28:49 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3C9g9as017453 for ; Fri, 12 Apr 2013 19:42:09 +1000 Message-ID: <5167D66F.3020704@linux.vnet.ibm.com> Date: Fri, 12 Apr 2013 17:39:59 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1364903250-10429-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1364903250-10429-10-git-send-email-xiawenc@linux.vnet.ibm.com> <878v4qxu1z.fsf@blackfin.pond.sub.org> <5166521E.8060201@linux.vnet.ibm.com> <87bo9lfes4.fsf@blackfin.pond.sub.org> <20130411084401.47405e80@redhat.com> <5166B5D9.1010906@redhat.com> <20130411093914.24941714@redhat.com> <51677CAE.5090805@linux.vnet.ibm.com> <51677DDE.6000703@redhat.com> In-Reply-To: <51677DDE.6000703@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, Markus Armbruster , pbonzini@redhat.com, Luiz Capitulino 于 2013-4-12 11:22, Eric Blake 写道: > On 04/11/2013 09:17 PM, Wenchao Xia wrote: > >>> >>>> Hmm, as I typed that, I did another search of qemu-schema.json - we have >>>> the type 'ImageInfo' defined, but none of the existing 'command's ever >>>> call out the use of that type. Is it a type we are only using >>>> internally to date, and where this is the first QMP command that would >>>> actually expose SnapshotInfo or ImageInfo to a management app? Then >>>> maybe we _CAN_ modify SnapshotInfo, clean up all the internal code, and >>>> provide a saner type for the first time that QMP can actually use it. >>> >>> IIRC, it's being used by qemu-img. As it's not trivial to determine if >>> the field has users and as what goes in the schema is to be considered >>> stable, >>> it's better to keep the field. Instead, we could add a better field and >>> deprecate the current one. >>> >> I remember there is a patch laster year made "qemu-img info" dump out >> json strings, where vm-clock-sec is dumped out. > > Ah, so it's not QMP exposing it, but qemu-info in JSON mode. Still, > changing that output to delete a field might break existing tools; > adding a field might be safer, but then you'd have redundant information > in the old style for old tools, as well as the added field. > It seems keeping it, is what best we can do now. Markus, are you OK with it? -- Best Regards Wenchao Xia