From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQbCQ-0005Qc-NE for qemu-devel@nongnu.org; Fri, 12 Apr 2013 06:27:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQbCN-0001Nc-2V for qemu-devel@nongnu.org; Fri, 12 Apr 2013 06:27:18 -0400 Received: from mail-qa0-f49.google.com ([209.85.216.49]:43924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQbCM-0001NC-VE for qemu-devel@nongnu.org; Fri, 12 Apr 2013 06:27:15 -0400 Received: by mail-qa0-f49.google.com with SMTP id i13so783918qae.15 for ; Fri, 12 Apr 2013 03:27:14 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5167E179.4030202@redhat.com> Date: Fri, 12 Apr 2013 12:27:05 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1365695085-27970-1-git-send-email-stefanha@redhat.com> <20130412080202.GB3426@dhcp-200-207.str.redhat.com> <20130412094936.GA4458@stefanha-thinkpad.redhat.com> <20130412100401.GD3426@dhcp-200-207.str.redhat.com> In-Reply-To: <20130412100401.GD3426@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Anthony Liguori , pingfank@linux.vnet.ibm.com, qemu-devel@nongnu.org, Stefan Hajnoczi Il 12/04/2013 12:04, Kevin Wolf ha scritto: > Or actually, if you want to avoid .bdrv_drain for now, the patch that I > started when I thought a bit about this, had a default .bdrv_drain > implementation that just forwarded the request to bs->file if it wasn't > implemented by a block driver. For the QED case, this would work. It's similar to bdrv_co_flush. Drain bs first, then bs->backing_hd (this is not needed in bdrv_co_flush), then bs->file, then the driver can do it on other files. Paolo