From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQbGE-0000Kx-S0 for qemu-devel@nongnu.org; Fri, 12 Apr 2013 06:31:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQbGB-0002mm-MJ for qemu-devel@nongnu.org; Fri, 12 Apr 2013 06:31:14 -0400 Received: from mail-qe0-f43.google.com ([209.85.128.43]:61423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQbGB-0002mi-Id for qemu-devel@nongnu.org; Fri, 12 Apr 2013 06:31:11 -0400 Received: by mail-qe0-f43.google.com with SMTP id f6so1450404qej.30 for ; Fri, 12 Apr 2013 03:31:11 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5167E267.6070204@redhat.com> Date: Fri, 12 Apr 2013 12:31:03 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1365600207-21685-1-git-send-email-pbonzini@redhat.com> <20130410175934.GA5213@amit.redhat.com> <51667B36.9020107@redhat.com> <20130412092410.GC17454@amit.redhat.com> In-Reply-To: <20130412092410.GC17454@amit.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel , Amit Shah Il 12/04/2013 11:24, Amit Shah ha scritto: > Can you try multiple writes from the guest? At least 3-4? QEMU > doesn't detect a backend getting closed right away (another bug), so > the freeze doesn't trigger til qemu detects there's no chardev > anymore. All writes after the second will hang and ^C will return bash: echo: write error: Interrupted system call Same for "yes > /dev/vport0p1". The writes hang as soon as I exit nc on the host, and ^C exits cleanly to the shell. I think this patch is obvious. You might be seeing another bug that should be fixed separately. Paolo >>> There's a slight difference in my old qemu tree, I have Hans's >>> "virtio-console: Remove any pending watches on close" patch applied, >>> which makes use of the tag obtained on adding the watch. That patch >>> hasn't found its way to master yet, but it should go in soon. >> >> I don't have that patch in my (new) tree. It's vanilla upstream QEMU. > > Yep, I tested upstream QEMU from master as well. (It's just my 'old' > qemu tree which has Hans's patches too.) > > Amit > >