From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34980)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UQbaw-0006io-J0
	for qemu-devel@nongnu.org; Fri, 12 Apr 2013 06:52:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UQbav-0002WZ-CL
	for qemu-devel@nongnu.org; Fri, 12 Apr 2013 06:52:38 -0400
Received: from cantor2.suse.de ([195.135.220.15]:34090 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UQbav-0002Ph-5i
	for qemu-devel@nongnu.org; Fri, 12 Apr 2013 06:52:37 -0400
Message-ID: <5167E747.2020106@suse.de>
Date: Fri, 12 Apr 2013 12:51:51 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1365730875-22854-1-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1365730875-22854-1-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] bswap: fix compiler warning
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, David Gibson <david@gibson.dropbear.id.au>

Am 12.04.2013 03:41, schrieb Alexey Kardashevskiy:
> The bswap functions use memcpy but the bswap.h header itself does not s=
eem to
> include it in some configuration such as cross compiling for powerpc64
> on x86_64 machine (gcc 4.6.3 from ftp.kernel.org, headers/libs from FC1=
8/ppc64),
> the example warning is below.
>=20
> The patch explicitly includes string.h.
>=20
>   CC    ppc64-softmmu/hw/virtio/virtio.o
> In file included from /home/alexey/qemu/include/libfdt_env.h:22:0,
>                  from /home/alexey/qemu/../lib4qemu/usr/include/libfdt.=
h:54,
>                  from /home/alexey/qemu/hw/nvram/spapr_nvram.c:25:
> /home/alexey/qemu/include/qemu/bswap.h: In function 'lduw_p':
> /home/alexey/qemu/include/qemu/bswap.h:244:5: warning: implicit declara=
tion of function 'memcpy' [-Wimplicit-function-declaration]
> /home/alexey/qemu/include/qemu/bswap.h:244:5: warning: incompatible imp=
licit declaration of built-in function 'memcpy' [enabled by default]
>=20
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  include/qemu/bswap.h |    2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
> index d3af35d..d50de0d 100644
> --- a/include/qemu/bswap.h
> +++ b/include/qemu/bswap.h
> @@ -1,6 +1,8 @@
>  #ifndef BSWAP_H
>  #define BSWAP_H
> =20
> +#include <string.h>
> +
>  #include "config-host.h"
>  #include <inttypes.h>
>  #include <limits.h>

Including string.h is certainly the right thing to do, but why do you
single it out first?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg