From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQcxB-0006jp-NL for qemu-devel@nongnu.org; Fri, 12 Apr 2013 08:19:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQcxA-00029I-HY for qemu-devel@nongnu.org; Fri, 12 Apr 2013 08:19:41 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37042 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQcxA-00029A-BP for qemu-devel@nongnu.org; Fri, 12 Apr 2013 08:19:40 -0400 Message-ID: <5167FBDB.1080402@suse.de> Date: Fri, 12 Apr 2013 14:19:39 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1365739943-30194-1-git-send-email-lig.fnst@cn.fujitsu.com> <1365739943-30194-3-git-send-email-lig.fnst@cn.fujitsu.com> In-Reply-To: <1365739943-30194-3-git-send-email-lig.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/3] debugcon: fix compiler warning when open DEBUG_DEBUGCON List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liguang Cc: qemu-devel@nongnu.org Am 12.04.2013 06:12, schrieb liguang: > compiler warnings: > CC hw/char/debugcon.o > hw/char/debugcon.c: In function =E2=80=98debugcon_ioport_write=E2=80=99= : > hw/char/debugcon.c:58: warning: format =E2=80=98%02x=E2=80=99 expects t= ype =E2=80=98unsigned int=E2=80=99, but argument 3 has type =E2=80=98uint= 64_t=E2=80=99 > hw/char/debugcon.c: In function =E2=80=98debugcon_ioport_read=E2=80=99: > hw/char/debugcon.c:70: warning: format =E2=80=98%04x=E2=80=99 expects t= ype =E2=80=98unsigned int=E2=80=99, but argument 2 has type =E2=80=98hwad= dr=E2=80=99 >=20 > Signed-off-by: liguang > --- > hw/char/debugcon.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c > index b52cbeb..4cf07c6 100644 > --- a/hw/char/debugcon.c > +++ b/hw/char/debugcon.c > @@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwadd= r addr, uint64_t val, > unsigned char ch =3D val; > =20 > #ifdef DEBUG_DEBUGCON > - printf(" [debugcon: write addr=3D0x%04llx val=3D0x%02x]\n", addr, = val); > + printf(" [debugcon: write addr=3D0x%04llx val=3D0x%02llx]\n", addr= , val); > #endif > =20 > qemu_chr_fe_write(s->chr, &ch, 1); > @@ -67,7 +67,7 @@ static uint64_t debugcon_ioport_read(void *opaque, hw= addr addr, unsigned width) > DebugconState *s =3D opaque; > =20 > #ifdef DEBUG_DEBUGCON > - printf("debugcon: read addr=3D0x%04x\n", addr); > + printf("debugcon: read addr=3D0x%04llx\n", addr); > #endif > =20 > return s->readback; Please see PRIx comment on 1/3. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg