From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQeEp-0002F5-S7 for qemu-devel@nongnu.org; Fri, 12 Apr 2013 09:42:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQeEo-00075a-7i for qemu-devel@nongnu.org; Fri, 12 Apr 2013 09:41:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQeEn-00075O-VK for qemu-devel@nongnu.org; Fri, 12 Apr 2013 09:41:58 -0400 Message-ID: <51680EF5.2010509@redhat.com> Date: Fri, 12 Apr 2013 15:41:09 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1365745929-24871-3-git-send-email-mrhines@linux.vnet.ibm.com> <5167EBB5.4010005@redhat.com> <51680C1D.9050803@linux.vnet.ibm.com> In-Reply-To: <51680C1D.9050803@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/8] rdma: core rdma logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael R. Hines" Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com Il 12/04/2013 15:29, Michael R. Hines ha scritto: > > Oh, thank you. Huge bug - I need to introduce a "COMPRESS" > message for this page into the protocol just like we already have > for TCP and bypass the current chunk. It's okay to send the page uncompressed if it's been registered already. This way you skip most is_zero_page checks after the bulk phase. I just care that a page is never registered if it is zero and never changes. Paolo > I knew I was forgetting about compress - some little angel on my > shoulder was telling me I forgot something but I couldn't remember =)