From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URdbB-0007ST-0Y for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:13:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URdb9-0006B9-L8 for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:13:08 -0400 Received: from mail-pb0-f42.google.com ([209.85.160.42]:44901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URdb9-0006AH-EY for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:13:07 -0400 Received: by mail-pb0-f42.google.com with SMTP id up7so2353863pbc.15 for ; Mon, 15 Apr 2013 00:13:06 -0700 (PDT) Message-ID: <516BA87A.2020107@ozlabs.ru> Date: Mon, 15 Apr 2013 17:12:58 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1365993073-4659-1-git-send-email-aik@ozlabs.ru> <8761zofezy.fsf@blackfin.pond.sub.org> In-Reply-To: <8761zofezy.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Peter Maydell , qemu-devel@nongnu.org, Blue Swirl , Gerd Hoffmann , Stefan Hajnoczi , David Gibson On 04/15/2013 05:08 PM, Markus Armbruster wrote: > Alexey Kardashevskiy writes: > >> The assert.h header file from Fedora18 does not have #ifdef-#endif >> brackets around __assertXXXX function so it cannot compile with >> the -Wredundant-decls switch on. >> >> Some Linux distributions (such as Debian Wheezy) still do have those >> brackets arounb __assertXXXX functions (#ifndef _ASSERT_H_DECLS) but >> the version of assert.h on http://sourceware.org/git/?p=glibc.git does not >> so we should not be using -Wredundant-decls. >> >> The patch removes it. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> include/ui/qemu-pixman.h | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h >> index b032f52..6f473f9 100644 >> --- a/include/ui/qemu-pixman.h >> +++ b/include/ui/qemu-pixman.h >> @@ -7,13 +7,7 @@ >> #define QEMU_PIXMAN_H >> >> /* pixman-0.16.0 headers have a redundant declaration */ >> -#ifdef CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE >> -#pragma GCC diagnostic ignored "-Wredundant-decls" >> -#endif >> #include >> -#ifdef CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE >> -#pragma GCC diagnostic error "-Wredundant-decls" >> -#endif >> >> #include "qemu/typedefs.h" > > Patch description doesn't seem to fit the patch. The patch doesn't > remove -Wredundant-decls, it removes its suppression in one specific > place. Please advise. The patch removes both suppression AND enabling, the second chunk enabled this check back after #include, no matter if it was enabled or not. > Oh, and use a spell-checker :) The one build into thunderbird does not show any spelling errors (except file names, of course) :) -- Alexey