From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URdoD-0005Hb-Vj for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:26:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URdoA-0002Jw-TQ for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:26:37 -0400 Received: from mail-pb0-f47.google.com ([209.85.160.47]:34637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URdoA-0002Ji-NK for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:26:34 -0400 Received: by mail-pb0-f47.google.com with SMTP id rq13so2350134pbb.6 for ; Mon, 15 Apr 2013 00:26:33 -0700 (PDT) Message-ID: <516BABA1.8030205@ozlabs.ru> Date: Mon, 15 Apr 2013 17:26:25 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1365993073-4659-1-git-send-email-aik@ozlabs.ru> In-Reply-To: Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Blue Swirl , David Gibson , qemu-devel@nongnu.org, Stefan Hajnoczi , Gerd Hoffmann On 04/15/2013 05:18 PM, Peter Maydell wrote: > On 15 April 2013 03:31, Alexey Kardashevskiy wrote: >> The assert.h header file from Fedora18 does not have #ifdef-#endif >> brackets around __assertXXXX function so it cannot compile with >> the -Wredundant-decls switch on. >> >> Some Linux distributions (such as Debian Wheezy) still do have those >> brackets arounb __assertXXXX functions (#ifndef _ASSERT_H_DECLS) but >> the version of assert.h on http://sourceware.org/git/?p=glibc.git does not >> so we should not be using -Wredundant-decls. >> >> The patch removes it. > > This commit message seems to be missing any mention of > which versions of pixman this change breaks and why > it's OK now to break compiling against them... The change does not _break_ anything. By default, it will just generate warnings, but only if "-Wredundant-decls" is set. The second removed chunk in the patch is the problem as it: 1) enables -Wredundant-decls even if it was not enabled before; 2) makes -Wredundant-decls an error, not just a warning. Default assert.h shipped with Fedora Core 18 (pretty recent and popular distribution, I would say) cannot compile with -Wredundant-decls as an error so we should either avoid -Wredundant-decls or watch where we include assert.h very carefully. >> Signed-off-by: Alexey Kardashevskiy >> --- >> include/ui/qemu-pixman.h | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h >> index b032f52..6f473f9 100644 >> --- a/include/ui/qemu-pixman.h >> +++ b/include/ui/qemu-pixman.h >> @@ -7,13 +7,7 @@ >> #define QEMU_PIXMAN_H >> >> /* pixman-0.16.0 headers have a redundant declaration */ > > ...and if it's a correct change it should be removing the > comment as well, since it would no longer apply. > >> -#ifdef CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE >> -#pragma GCC diagnostic ignored "-Wredundant-decls" >> -#endif >> #include >> -#ifdef CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE >> -#pragma GCC diagnostic error "-Wredundant-decls" >> -#endif >> >> #include "qemu/typedefs.h" >> >> -- >> 1.7.10.4 > > thanks > -- PMM > -- Alexey