From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URemP-0000HD-5R for qemu-devel@nongnu.org; Mon, 15 Apr 2013 04:28:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URemH-0001uw-2V for qemu-devel@nongnu.org; Mon, 15 Apr 2013 04:28:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URemG-0001up-ID for qemu-devel@nongnu.org; Mon, 15 Apr 2013 04:28:40 -0400 Message-ID: <516BBA2D.5000704@redhat.com> Date: Mon, 15 Apr 2013 10:28:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20130412104802.GA23467@redhat.com> <5167E797.2050103@redhat.com> <20130412112553.GB23467@redhat.com> <51681DAA.3000503@redhat.com> <20130414115911.GA4923@redhat.com> <516ABCCC.207@linux.vnet.ibm.com> <20130414160327.GB7165@redhat.com> <516ADBEA.5090100@linux.vnet.ibm.com> <20130414183041.GC7165@redhat.com> <516AFE23.104@linux.vnet.ibm.com> <20130414211055.GF7165@redhat.com> <516B529C.5090503@linux.vnet.ibm.com> In-Reply-To: <516B529C.5090503@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael R. Hines" Cc: aliguori@us.ibm.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com Il 15/04/2013 03:06, Michael R. Hines ha scritto: >>>>> Next, decide if you want dynamic page registration on the server-side. >>>>> For example, if you have an 8GB RAM virtual machine, but only 1GB >>>>> is in active use, then disabling this feature will cause all 8GB to >>>>> be pinned and resident in memory. This feature mostly affects the >>>>> bulk-phase round of the migration and can be disabled for extremely >>>>> high-performance RDMA hardware using the following command: >>>>> QEMU Monitor Command: >>>>> $ migrate_set_capability chunk_register_destination off # enabled >>>>> by default >>>>> >>>>> Performing this action will cause all 8GB to be pinned, so if that's >>>>> not what you want, then please ignore this step altogether. >>>> This does not make it clear what is the benefit of disabling this >>>> capability. I think it's best to avoid options, just use chunk >>>> based always. >>>> If it's here "so people can play with it" then please rename >>>> it to something like "x-unsupported-chunk_register_destination" >>>> so people know this is unsupported and not to be used for production. >>> Again, please drop the request for removing chunking. >>> >>> Paolo already told me to use "x-rdma" - so that's enough for now. >> >> You are adding a new command that's also experimental, so you must tag >> it explicitly too. > > The entire migration is experimental - which by extension makes the > capability experimental. You still have to mark it as "x-". Of course not "x-unsupported-", that is a pleonasm. Paolo